Skip to content

[java] DriverFinderTest property fixture doesn't clear/restore selenium.webdriver.verbose #17836

Description

@MohabMohie

Motivation

Follow-up to #17832/#17833. That PR's round-2 review pass fixed the identical fixture-hygiene gap (test setup only saving/clearing selenium.debug, not its legacy alias selenium.webdriver.verbose) in LoggingOptionsTest.java, RemoteWebDriverInitializationTest.java, and RetryRequestTest.java.

java/test/org/openqa/selenium/remote/service/DriverFinderTest.java:81-100 has the same gap: its property save/restore only handles selenium.debug, so a JVM with selenium.webdriver.verbose set externally could leak state across tests in this file. It was out of scope for the round-2 coder (not in the original findings list) so it's tracked here rather than fixed silently.

Suggested fix

Mirror the fixture pattern already applied to the three files above: save both properties before the test, clear both, restore both after.

Context

Umbrella tracker: #17833

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions