Repository navigation
|
Hi. I'm trying to use license-eyes as a pre-commit hook to check/fix headers in a multi-license project. While the Currently if we have two headers A and B, they will be applied to But it would make more sense to intersect the candidate files and apply each header to: Maybe there can be a new cli flag if we want to preserve existing behavior. Lmk what you think! |
Replies: 1 comment 1 reply
|
Thanks for raising this. It is a bug, not just a missing option. With multiple headers, the command-line paths replaced every header's apache/skywalking-eyes#298 makes the behavior you proposed the default, with no new flag: A header counts the selected files that its One note for multi-license configs: a file that the After it's merged, you can use it before the next release with |
Thanks for raising this. It is a bug, not just a missing option. With multiple headers, the command-line paths replaced every header's
paths, so each file was checked against every header.header checkcould never pass, andheader fixinserted all the headers into every file.apache/skywalking-eyes#298 makes the behavior you proposed the default, with no new flag:
A header counts the selected files that its
pathsdon't cover as ignored, the same as a run without command-line paths. With a single header and the defaultpaths: ['**'], nothing changes.One note for multi-license configs: a file that the
pathsof several headers cov…