Skip to content

Commit 467c1a1

Browse files
DavertMikclaude
andcommitted
test(cdp-browser): move click and visibility fixtures into test app pages
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 parent 2dc2969 commit 467c1a1

4 files changed

Lines changed: 49 additions & 31 deletions

File tree

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
<html>
2+
<body>
3+
<a id="card-link" href="#">
4+
<div style="height:20px">card</div>
5+
</a>
6+
<a id="empty-link" href="#"></a>
7+
<span id="hidden-card" style="display:contents">
8+
<div style="display:none">hidden</div>
9+
</span>
10+
</body>
11+
</html>
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
<html>
2+
<body>
3+
<div id="mousedown-trigger" tabindex="0" style="height:20px">open</div>
4+
<div id="mousedown-menu" style="display:none">menu</div>
5+
<button id="disabled-btn" disabled>off</button>
6+
<script>
7+
window.__clickEvents = []
8+
var trigger = document.getElementById('mousedown-trigger')
9+
;['pointerdown', 'mousedown', 'focus', 'pointerup', 'mouseup', 'click'].forEach(function (type) {
10+
trigger.addEventListener(type, function () { window.__clickEvents.push(type) })
11+
})
12+
trigger.addEventListener('mousedown', function () {
13+
document.getElementById('mousedown-menu').style.display = 'block'
14+
})
15+
document.getElementById('disabled-btn').addEventListener('mousedown', function () {
16+
window.__clickEvents.push('disabled-mousedown')
17+
})
18+
</script>
19+
</body>
20+
</html>
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
<html>
2+
<body>
3+
<ul>
4+
<li id="menu-item">
5+
<button type="button" id="menu-button" style="display:block;width:100%;height:30px"><span>New suite</span></button>
6+
</li>
7+
</ul>
8+
<div id="opened" style="display:none">opened</div>
9+
<script>
10+
document.getElementById('menu-button').addEventListener('click', function () {
11+
document.getElementById('opened').style.display = 'block'
12+
})
13+
</script>
14+
</body>
15+
</html>

‎test/helper/CDPBrowser_obscura_test.js‎

Lines changed: 3 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -81,35 +81,16 @@ describe('Obscura helper (self-managed obscura serve)', function () {
8181
})
8282

8383
it('sees an inline link that wraps only block children', async function () {
84-
await I.amOnPage('/')
84+
await I.amOnPage('/form/inline_wrapper')
8585
if (I.capabilities.layout !== 'real') this.skip()
86-
await I.executeScript(() => {
87-
const wrapper = document.createElement('div')
88-
wrapper.innerHTML = '<a id="card-link" href="#"><div style="height:20px">card</div></a><a id="empty-link" href="#"></a><span id="hidden-card" style="display:contents"><div style="display:none">x</div></span>'
89-
document.body.appendChild(wrapper)
90-
})
9186
await I.seeElement('#card-link')
9287
await I.waitForVisible('#card-link', 1)
9388
await I.dontSeeElement('#empty-link')
9489
await I.dontSeeElement('#hidden-card')
9590
})
9691

9792
it('clicks with the pointer and mouse events a real click fires', async () => {
98-
await I.amOnPage('/')
99-
await I.executeScript(() => {
100-
const wrapper = document.createElement('div')
101-
wrapper.innerHTML = '<div id="mousedown-trigger" tabindex="0" style="height:20px">open</div><div id="mousedown-menu" style="display:none">menu</div><button id="disabled-btn" disabled>off</button>'
102-
document.body.appendChild(wrapper)
103-
window.__clickEvents = []
104-
const trigger = document.getElementById('mousedown-trigger')
105-
for (const type of ['pointerdown', 'mousedown', 'focus', 'pointerup', 'mouseup', 'click']) {
106-
trigger.addEventListener(type, () => window.__clickEvents.push(type))
107-
}
108-
trigger.addEventListener('mousedown', () => {
109-
document.getElementById('mousedown-menu').style.display = 'block'
110-
})
111-
document.getElementById('disabled-btn').addEventListener('mousedown', () => window.__clickEvents.push('disabled-mousedown'))
112-
})
93+
await I.amOnPage('/form/mousedown_trigger')
11394
await I.click('#mousedown-trigger')
11495
await I.forceClick('#disabled-btn')
11596
const events = await I.executeScript(() => window.__clickEvents)
@@ -118,17 +99,8 @@ describe('Obscura helper (self-managed obscura serve)', function () {
11899
})
119100

120101
it('clicks the control a wrapper element covers, like a real click lands', async function () {
121-
await I.amOnPage('/')
102+
await I.amOnPage('/form/wrapped_button')
122103
if (I.capabilities.layout !== 'real') this.skip()
123-
await I.executeScript(() => {
124-
const wrapper = document.createElement('div')
125-
wrapper.innerHTML =
126-
'<ul><li id="menu-item"><button type="button" id="menu-button" style="display:block;width:100%;height:30px"><span>New suite</span></button></li></ul><div id="opened" style="display:none">opened</div>'
127-
document.body.prepend(wrapper)
128-
document.getElementById('menu-button').addEventListener('click', e => {
129-
if (e.target.closest('#menu-button')) document.getElementById('opened').style.display = 'block'
130-
})
131-
})
132104
await I.click('#menu-item')
133105
await I.seeElement('#opened')
134106
})

0 commit comments

Comments
 (0)