Repository navigation
add tests for version util functions - #13991
Closed
RavSinghChandan wants to merge 2 commits into
Closed
RavSinghChandan wants to merge 2 commits into
RavSinghChandan wants to merge 2 commits into
Conversation
Author
|
Closing this since it's been open a while without review. Happy to reopen if it's still useful. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
noticed a few of the version helpers in
util.pyhad no tests —get_minor_version_range,get_base_versionandsplit_requirement— so added parametrized tests for them intest_misc.py, next to the existingtest_minor_version.nothing fancy, just pins the current behaviour (the range string, stripping prerelease bits off the base version, and splitting a requirement into name + specifier).
also included the signed contributor agreement since this is my first PR here.