Repository navigation
Pass the running interpreter to uv when downloading models - #14071
Closed
davrens101 wants to merge 1 commit into
Closed
davrens101 wants to merge 1 commit into
davrens101 wants to merge 1 commit into
Conversation
Signed-off-by: davrens101 <davrens101@users.noreply.github.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14055.
spacy.cli.download._get_pip_install_cmd()falls back to["uv", "pip", "install"]whenpipisn't importable (e.g. auv venv-created environment). That command doesn't say which interpreter to install into, so uv has to discover an environment. When the venv isn't activated (VIRTUAL_ENVunset) and the working directory isn't the venv's parent, uv exits with:and
spacy downloadfails even though the interpreter running spaCy is the obvious target. The pip branch already targets it viasys.executable.This adds
--python sys.executableto the uv fallback.Reproduced with uv 0.13.7 from a directory with no
.venvandVIRTUAL_ENVunset:Before:
After (command spaCy now builds):
Added a unit test in
spacy/tests/test_cli.pyfor the constructed command; it fails before this change and passes after.pytest spacy/tests/test_cli.py -k downloadpasses.Checklist
spacyCLI.