Repository navigation
fs: normalize paths with dot segments in rm and rmSync #61084
Triggered via pull request
October 3, 2026 01:23
RohithPariki
opened
#66472
Status
Failure
Total duration
34s
Artifacts
–
commit-lint.yml
on: pull_request_target
lint-commit-message
29s
Annotations
1 error and 1 warning
|
lint-commit-message
# 0ee0e2e943bd87ea8ef329bc6b5f1028eb5aec0a
ok 1 assisted-by-is-trailer: no Assisted-by metadata
ok 2 co-authored-by-is-trailer: no Co-authored-by metadata
ok 3 fixes-url: Valid fixes URL. [https://github.com/nodejs/node/issues/61958]
ok 4 line-after-title: blank line after title
not ok 5 line-length: Line should be <= 72 columns.
---
{
found: 271,
compare: '<=',
wanted: 72,
at: {
line: 4,
column: 72,
body: [
'',
"When paths containing '.' or '..' components (e.g., 'a/b/../.') are passed to fs.rm(), fs.rmSync(), or fs.promises.rm(), the different codepaths (native binding.rmSync vs JS rimraf) could produce inconsistent results because the path was used as-is without normalization.",
'',
'Add pathModule.normalize() after getValidatedPath() in all three rm variants to ensure dot-segment components are resolved before the path reaches the underlying removal implementation.',
'',
'Fixes: https://github.com/nodejs/node/issues/61958',
'Signed-off-by: Rohith Pariki <rohithpariki@gmail.com>'
]
}
}
...
not ok 6 line-length: Line should be <= 72 columns.
---
{
found: 185,
compare: '<=',
wanted: 72,
at: {
line: 6,
column: 72,
body: [
'',
"When paths containing '.' or '..' components (e.g., 'a/b/../.') are passed to fs.rm(), fs.rmSync(), or fs.promises.rm(), the different codepaths (native binding.rmSync vs JS rimraf) could produce inconsistent results because the path was used as-is without normalization.",
'',
'Add pathModule.normalize() after getValidatedPath() in all three rm variants to ensure dot-segment components are resolved before the path reaches the underlying removal implementation.',
'',
'Fixes: https://github.com/nodejs/node/issues/61958',
'Signed-off-by: Rohith Pariki <rohithpariki@gmail.com>'
]
}
}
...
ok 7 signed-off-by: has valid Signed-off-by
ok 8 subsystem: valid subsystems [fs]
ok 9 title-format: Title is formatted correctly.
0..9
# tests 9
# pass 7
# fail 2
# Please review the commit message guidelines:
# https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines
npm warn deprecated tap@16.3.10: Versions of tap before v18 are no longer maintained. Please upgrade.
npm warn deprecated rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported
npm warn deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm warn deprecated @humanwhocodes/config-array@0.13.0: Use @eslint/config-array instead
npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
npm warn deprecated libtap@1.4.1: This library is no longer used by node-tap, and is unmaintained.
npm warn deprecated eslint@8.57.1: This version is no longer supported. Please see https://eslint.org/version-support for other options.
|
|
Workflow execution policy warning (evaluate mode):
.github/workflows/commit-lint.yml#L1
On November 2, 2026, GitHub will restrict `pull_request_target` on public repositories by default. To continue allowing the event trigger, configure an Actions policy. Learn more: https://gh.io/securely-using-pull_request_target#default-policy-for-pull_request_target
|