Repository navigation
Improve temp dir cleanup in xe class - #68
BrennanGit wants to merge 7 commits into
Conversation
This was filling up CI machines
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Cleanup failures remain silent, forced termination can still leak directories, and the unrelated CI migration needs clarification.
Review effort: Balanced
Findings: 3
Open (3)
What changed in this PR
Improves cleanup of temporary directories used for XE inspection and simulator execution.
Changes:
- Adds explicit, idempotent XE cleanup.
- Ensures cleanup during initialization and simulation failures.
- Migrates the Jenkins pipeline to newer shared-library APIs.
| File | Description |
|---|---|
lib/python/Pyxsim/xe.py |
Adds explicit temporary-directory cleanup. |
lib/python/Pyxsim/pyxsim.py |
Cleans XE resources during termination. |
lib/python/Pyxsim/__init__.py |
Adds cleanup around simulation and tracing. |
Jenkinsfile |
Updates CI library and repository checks. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| finally: | ||
| xsi.terminate() |
We really need to add tests to his repo! What was the high-level problem you were trying to solve here? |
|
Basically, the ubu builders got overwhelmed recently by builds from lib_voice and soundwire which killed them with OOM errors. When I tried to bring them back, they got stuck on a start job for >30m which turned out to be them deleting thousands upon thousands of small directories in /tmp. Even now if I go and check a "healthy" builder, there are 31423 folders in /tmp with the contents like I checked a couple of the elf headers and found some for soundwire and for i3c so I suspect its the shared code in pyxsim thats not cleaning up the temp dirs properly. |

I'm not sure a good way to actually test the things in this repo so would appreciate some help in review.