You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Enhancement: round fluid values in log messages #276
Hi,
while it is only a minor inconvenience I think it might be a nice improvement to slightly round the fluid values being displayed in the LTN messages.
(not sure why there is the bug label, it was not my intention to raise this as a bug, sorry)
I understand that you would consider additional logic just to get this done "not worth it" and I agree 100%.
From my perspective I can't think of any situations were it would be an issue to just round all the numbers in the "itemcount itemtype" part.
--> rounding fluids values: intended
--> rounding item counts: rounding an integer has no effect
--> rounding item stack counts: I don't know if LTN even even supports delivering 3.74 stacks, but I don't see any harm rounding the displayed value to 2 decimals.
This would meant that there is no "additional logic" required, just an additional ceil(...) where the info message is generated.
Activity
[-]Enhancement round fluid values in log messages[/-][+]Enhancement: round fluid values in log messages[/+]nicolas-lang commentedon Nov 7, 2021
Hi,
while it is only a minor inconvenience I think it might be a nice improvement to slightly round the fluid values being displayed in the LTN messages.
(not sure why there is the bug label, it was not my intention to raise this as a bug, sorry)
0ptera commentedon Nov 14, 2021
Would require either:
Neither option seems worth it to me.
nicolas-lang commentedon Nov 14, 2021
I understand that you would consider additional logic just to get this done "not worth it" and I agree 100%.
From my perspective I can't think of any situations were it would be an issue to just round all the numbers in the "itemcount itemtype" part.
--> rounding fluids values: intended
--> rounding item counts: rounding an integer has no effect
--> rounding item stack counts: I don't know if LTN even even supports delivering 3.74 stacks, but I don't see any harm rounding the displayed value to 2 decimals.
This would meant that there is no "additional logic" required, just an additional ceil(...) where the info message is generated.
( P.S. this is very low priority for sure. )
danbopes commentedon Feb 8, 2022
I too found the weird decimal point cluttering to my UI, and actively searched to try and find a setting to round these numbers to no avail.