Repository navigation
feat: adapt the SDK to dsh 0.2.1-rc.1 (new wire wrappers + verified baseline) - #26
Merged
Merged
Conversation
Plan 12 Task 2: bump the exact pin at all three sites (install step, npm cache-key suffix, fail-loud PATH check) to the runtime baseline re-verified at deepseek-harness `dsh-v0.2.1` rc.1 (1600d8a1, 2026-10-16), and rewrite the pin rationale for that baseline (wire core unchanged, request map additive, session events still opaque). Registry probe: `npm view @deepseek-ai/dsh@0.2.1-rc.1 version` -> 0.2.1-rc.1. Gates: cargo fmt --check, cargo clippy --all-targets -- -D warnings.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-aligns the crate to
@deepseek-ai/dsh@0.2.1-rc.1and adapts the new wire capabilities the reference SDKs expose.What changed
DeepSeekHarness::resume_session,Session::get_working_directory,Session::set_working_directory, plus the matchingHarnessClientmethods (session/resume,session/working-directory/get|set).session/waitis deliberately not wrapped: neither the Python nor the TypeScript SDK exposes it.0.2.1-rc.1; both frozen specs re-baselined to that tag (41-row re-verification, 39 PASS / 2 FAIL, both stale citations corrected).Evidence
cargo test197 passed;cargo fmt --checkandcargo clippy --all-targets -- -D warningsclean.SdkProtocol/JsonRpcerror mapping.Known unverified
Whether a stored
$DSH_HOME/.credentials.yamlentry pre-empts an injectedDEEPSEEK_API_KEYis an open question, recorded in the spec, both READMEs and the rustdoc — no outcome is asserted.