Repository navigation
Remove tests/avifoptionstest.c - #3364
Merged
wantehchang merged 1 commit intoSep 16, 2026
Merged
Conversation
Member
Author
|
cc: @agamal026 FYI. |
y-guyon
approved these changes
Sep 15, 2026
tests/avifoptionstest.c was added in AOMediaCodec#3350, but I don't have time to make it conform to the style of the tests we wrote ourselves. The test also verifies properties of the current implementation, such as the initial capacity of 4 and the fact that we grow an avif array by doubling. Some of that may be necessary so that we can count the number of codec-specific options we need to add before the avif array is reallocated, but it could make the test a maintenance burden.
wantehchang
force-pushed
the
remove-avifoptionstest
branch
from
September 16, 2026 17:28
a06f08f to
5ccc568
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/avifoptionstest.c was added in
#3350, but I don't have time to make it conform to the style of the tests we wrote ourselves. The test also verifies properties of the current implementation, such as the initial capacity of 4 and the fact that we grow an avif array by doubling. Some of that may be necessary so that we can count the number of codec-specific options we need to add before the avif array is reallocated, but it could make the test a maintenance burden.