fix off-by-one in avifGetExifTiffHeaderOffset scan bound - #3400
Merged
y-guyon merged 1 commit intoOct 2, 2026
Merged
Conversation
y-guyon
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
avifGetExifTiffHeaderOffset scans the Exif payload for the TIFF header but bounds the loop with
*offset + 4 < exifSize, which stops one byte early and never checks the final four-byte window, so a header located in the last four bytes of the payload is reported as missing even though reading it there is in bounds. Changing the comparison to<=examines that last position. Added a regression test with the little- and big-endian headers placed at the end of the buffer.