[Mark2000]

Description

Merge one BSK is updated on pypi with spice PR: AVSLab/basilisk#1180

Uses new BSK spice behavior to limit overheads.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

How should this pull request be reviewed?

• By commit
• All changes at once

How Has This Been Tested?

Tested in BSK PR.

Checklist

• I have performed a self-review of my code
• I have commented my code in hard-to-understand areas
• I have made corresponding changes to the documentation and release notes
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works

[Copilot]

Pull request overview

Removes explicit SPICE-kernel unloading logic in WorldModel and TrajectorySimulator, aligning bsk_rl with updated Basilisk/SPICE behavior to reduce overhead and avoid relying on Python finalizers.

Changes:

• Removed __del__ implementations that called gravFactory.unloadSpiceKernels() in simulation/world and orbital utilities.
• Updated/renamed related unit tests and removed destructor-side-effect assertions.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
tests/unittest/sim/test_world.py	Updates unit tests to stop asserting explicit SPICE unload on object deletion; normalizes test names.
src/bsk_rl/utils/orbital.py	Removes SPICE-unload finalizer from TrajectorySimulator.
src/bsk_rl/sim/world.py	Removes SPICE-unload finalizer from WorldModel, relying on Basilisk’s updated behavior.

Comments suppressed due to low confidence (2)

src/bsk_rl/sim/world.py:205

• This change removes explicit SPICE kernel unloading from the world lifecycle. Since this behavior is now dependent on Basilisk providing automatic kernel cleanup, consider enforcing a minimum bsk/Basilisk version that includes the new SPICE behavior (or adding an explicit runtime/version check) so users running older bsk versions don’t accumulate loaded kernels across resets in a long-lived process.

        # setup Spice interface for some solar system bodies
        timeInitString = utc_init
        self.gravFactory.createSpiceInterface(
            path_ephem_data, timeInitString, epochInMsg=True
        )
        self.gravFactory.spiceObject.zeroBase = "earth"

        self.simulator.AddModelToTask(
            self.world_task_name, self.gravFactory.spiceObject, ModelPriority=priority
        )

    def setup_ephem_object(self, priority: int = 988, **kwargs) -> None:
        """Set up the ephemeris object to use with the SPICE library.

        Args:
            priority: Model priority.
            **kwargs: Passed to other setup functions.
        """
        self.ephemConverter = ephemerisConverter.EphemerisConverter()

src/bsk_rl/utils/orbital.py:553

• TrajectorySimulator no longer unloads SPICE kernels on object deletion. If this relies on newer Basilisk behavior, it would be safer to either (a) require that Basilisk version explicitly, or (b) provide an explicit cleanup/close method callers can invoke, since __del__ timing is non-deterministic and older Basilisk versions may keep kernels loaded across many simulator instantiations.

    @property
    def r_BP_P(self) -> interp1d:
        """Interpolator for r_BP_P."""
        if self.sim_time < self.dt * 3:
            self.extend_to(self.dt * 3)

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.