Skip to content

Feature/allow multiple scenarios - #361

Merged
LorenzzoQM merged 4 commits into
developfrom
feature/allow_multiple_scenarios
Oct 12, 2026
Merged

LorenzzoQM merged 4 commits into
developfrom
feature/allow_multiple_scenarios

Conversation

@LorenzzoQM

Copy link
Copy Markdown
Contributor

Description

Closes #360

Allows using multiple scenarios in the same simulation, tying different scenarios to different agents and rewarders. A new example script was added demonstrating how to use the new mixed scenario and mixed rewarder classes.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How should this pull request be reviewed?

  • By commit
  • All changes at once

How Has This Been Tested?

New unit and integration tests were added.

Future Work

This could be extended to a satellite being assigned to multiple scenarios, acting both in ground and space imaging. This would require some changes to the current flight software.

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation and release notes
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@LorenzzoQM LorenzzoQM self-assigned this Oct 7, 2026
Copilot AI balanced review requested due to automatic review settings October 7, 2026 20:44

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@LorenzzoQM
LorenzzoQM requested a review from Yume27 October 7, 2026 20:44
@LorenzzoQM
LorenzzoQM force-pushed the feature/allow_multiple_scenarios branch from 2223cfd to f267821 Compare October 7, 2026 20:48

@Yume27 Yume27 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this is a great new feature for handling complex mixed environments with different reward functions! I left a few comments, but they’re all pretty minor.

Comment thread examples/mixed_environment.ipynb Resolved
Comment thread src/bsk_rl/data/composition.py Resolved
Comment thread tests/integration/test_int_mixed.py Resolved
Comment thread examples/mixed_environment.ipynb Resolved
Comment thread examples/mixed_environment.ipynb Resolved
@LorenzzoQM
LorenzzoQM force-pushed the feature/allow_multiple_scenarios branch from f267821 to 52d8abf Compare October 12, 2026 00:21
@LorenzzoQM
LorenzzoQM merged commit 7810fc7 into develop Oct 12, 2026
15 of 16 checks passed
@LorenzzoQM
LorenzzoQM deleted the feature/allow_multiple_scenarios branch October 12, 2026 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow using multiple scenarios in the same environment

3 participants