Skip to content

Feature/allow reimaging with pending downlink - #365

Merged
LorenzzoQM merged 3 commits into
developfrom
feature/allow_reimaging_with_pending_downlink
Oct 20, 2026
Merged

LorenzzoQM merged 3 commits into
developfrom
feature/allow_reimaging_with_pending_downlink

Conversation

@LorenzzoQM

Copy link
Copy Markdown
Contributor

Description

Closes #364

Allows changing the default behavior to allow reimaging after cooldown if target's picture downlink is pending in space to space imaging scenarios.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How should this pull request be reviewed?

  • By commit
  • All changes at once

How Has This Been Tested?

Unit and integration tests were added.

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation and release notes
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@LorenzzoQM
LorenzzoQM requested review from Ethan-Weber and a balanced review from Copilot October 20, 2026 00:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@LorenzzoQM LorenzzoQM self-assigned this Oct 20, 2026

@Ethan-Weber Ethan-Weber left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR provides an option for space-to-space imaging scenarios where a target can be re-imaged before its previous image has been downlinked. When block_pending_targets=False, the target remains eligible for imaging after cooldown, even if one or more previous images are still pending downlink (or if downlink is not being considered in the scenario), but the existing pending image bookkeeping and cooldown logic are preserved. This keeps image history, reward accounting, and completion tracking consistent without forcing a strict “wait for downlink before another capture” policy.

@LorenzzoQM
LorenzzoQM merged commit 497dbb0 into develop Oct 20, 2026
15 of 16 checks passed
@LorenzzoQM
LorenzzoQM deleted the feature/allow_reimaging_with_pending_downlink branch October 20, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allows reimaging in space to space with pendning downlink

3 participants