Skip to content

fix: "go to details" from related entities opens the first tab - #4673

Draft
aam-digital-ci wants to merge 1 commit into
masterfrom
claude/vigilant-lamport-uiroin
Draft

aam-digital-ci wants to merge 1 commit into
masterfrom
claude/vigilant-lamport-uiroin

Conversation

@aam-digital-ci

Copy link
Copy Markdown
Collaborator

When "Go to details" is clicked in the popup of a related record, the router reuses the EntityDetailsComponent if the linked record has the same route config (e.g. /child/1 → /child/2). The link has no _tabIndex param, so TabStateMemoDirective left the tab group on the tab that was selected before.

The directive now remembers the current path. If a navigation moves to a different path and the URL holds no tab index, it switches to the first tab. A navigation that only changes query params of the same page (filters, the tab index itself) keeps the selected tab as before. The fix is in the shared directive, so any other link to a record of the same type (e.g. an entity reference on a details page) also opens the first tab.

Manual Testing Steps

Steps

  1. Open the details of a record whose related entities list shows records of a type that has more than one tab in its details view (e.g. a child, with a related entities list of the same or another type that has several tabs).
  2. Switch to a tab other than the first one (e.g. the tab with the related records list).
  3. Click a related record to open its popup, then click "Go to details" → the linked record opens on its first tab.
  4. Switch tabs on that record, then use the browser back button → the previous record is shown on the tab from the URL, as before.

PR Checklist

Before you request a manual PR review from someone, please go through all of this list:

  • manually tested (all) required functionality yourself and wrote clear steps for manual testing (including the config needed, in the all-features config)
  • reviewed the "Files changed" section of the PR briefly
  • added label "Final Review" to trigger UI regression testing (Argos visual review)
  • triggered CodeRabbit AI review by commenting "@coderabbitai review" (e2e tests run automatically on every push)
  • marked each code review comment as resolved (or commented on it with a question, if unsure)

--> then mark the PR "Ready for Review"



Generated by Claude Code

The router reuses the details component for another record of the same
type (e.g. "go to details" from a related entities popup), so the tab
group kept the previously selected tab. Start on the first tab when the
page changes without a tab index in the URL.

closes #4672

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PKaCy7ZNjyvZ2KAFm2Qaqb
@coderabbitai

coderabbitai Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Deployed to https://pr-4673.aam-digital.net/

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"go to details" from RelatedEntities should open the linked entity on its first tab

2 participants