Repository navigation
fix: "go to details" from related entities opens the first tab - #4673
Draft
aam-digital-ci wants to merge 1 commit into
Draft
aam-digital-ci wants to merge 1 commit into
aam-digital-ci wants to merge 1 commit into
Conversation
The router reuses the details component for another record of the same type (e.g. "go to details" from a related entities popup), so the tab group kept the previously selected tab. Start on the first tab when the page changes without a tab index in the URL. closes #4672 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PKaCy7ZNjyvZ2KAFm2Qaqb
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
Contributor
|
Deployed to https://pr-4673.aam-digital.net/ |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When "Go to details" is clicked in the popup of a related record, the router reuses the
EntityDetailsComponentif the linked record has the same route config (e.g./child/1→/child/2). The link has no_tabIndexparam, soTabStateMemoDirectiveleft the tab group on the tab that was selected before.The directive now remembers the current path. If a navigation moves to a different path and the URL holds no tab index, it switches to the first tab. A navigation that only changes query params of the same page (filters, the tab index itself) keeps the selected tab as before. The fix is in the shared directive, so any other link to a record of the same type (e.g. an entity reference on a details page) also opens the first tab.
Manual Testing Steps
Steps
PR Checklist
Before you request a manual PR review from someone, please go through all of this list:
--> then mark the PR "Ready for Review"
Generated by Claude Code