Graph Editor : UX Updates Towards "Keyboardless" Workflow by kwokcb · Pull Request #3043 · AcademySoftwareFoundation/MaterialX

kwokcb · 2026-08-19T14:37:27Z

Updates

Update #3037.
Fixes #3032.

Add "Add node" : RMB on background
Add "hamburger" control : LMB brings up context senstive menu.
- Adds in rename (1) and delete node.
- Others can easily add more items for menu equivalents or new functionality.
Fix so that focus (F) does not occur when using CTRL-F (search)

Notes:

(1) Rename is in-menu to avoid constant renaming causing "flashing" in UI and slow re-render on every keystroke.
(2) the remapping of pan should make it more consistent with DCCs / Web based editors and can handle 2-button mice / touch interfaces.

Implementation

Some refactoring for code reuse as much as possible for shared actions between keyboard vs mouse actions.

Results

New "hamburger" control

Rename node in context

Add node (via RMB)

- RMB add node - RMB on hamburger in node -> popup menu. Add only delete for now Fix: CTRL-F search without also trigger focus (F).

Add "rename" to menu.

- Bypass imgui node editor F key invocation which is always triggered regardless of modifiers. This is the main source of the bug.

- Disable hamburger on read-only nodes and disallow rename / delete on any read-only graphs.

- Extract out node width computation utility for us bye hamburger as well as previous pin placement.

…ed up pin layouts.

Disable RMB add popup on readonly graphs

kwokcb · 2026-08-21T02:37:56Z

 const float BASE_UI_FONT_SIZE = 18.0f;
 const float BASE_PIN_ICON_SIZE = 18.0f;
 const float MIN_PIN_ICON_SIZE = 18.0f;
+const float HDR_TEXT_INDENT = 4.0f;


Global header indent

kwokcb · 2026-08-21T02:39:00Z

    _layoutPending(false),
    _needsNavigation(false),
    _delete(false),
+    _nodeMenuToOpen(-1),


Track node menu popup and deletion info if delete chosen

kwokcb · 2026-08-21T02:40:08Z


+void Graph::drawNodeMenu(UiNodePtr node)
+{
+    const float buttonSize = computeHamburgerSize();


Node menu icon : "hamburger"

kwokcb · 2026-08-21T02:41:01Z

+
+float Graph::computeNodeContentWidth(UiNodePtr node)
+{
+    // Compute the node's content width (widest of the title row, shown


Utilitly to compute max text width for node

kwokcb · 2026-08-21T02:41:57Z

                    ImColor(ImColor(85, 85, 85, 255)), 0.f);
                ImGui::Indent(hdrTextIndent);
-                ImGui::Text("%s", node->getName().c_str());
+                ImGui::TextUnformatted(node->getName().c_str());


Extend title with node menu icon.

kwokcb · 2026-08-21T02:47:26Z

        addPinPopup();
        readOnlyPopup();
-        ImGui::PopStyleVar();
+        _nodeMenuRects.clear();


Fully clear state.

kwokcb · 2026-08-21T02:48:21Z

-                                _popup = true;
-                            }
-                        }
+                        deleteNodeById(id);


Uses common delete node logic.

kwokcb · 2026-08-21T02:50:18Z

+    // this frame and restore them immediately after.
+    if ((io2.KeyCtrl || io2.KeySuper) && ImGui::IsKeyPressed(ImGuiKey_F))
+    {
+        ed::EnableShortcuts(false);


This was very tricky to fix since you need to superscede the imgui node editor logic which always assumes F key (regardless of modifier) is pressed. Reulsint in CMD/CTRL-F always kicking off "focus on node" logic.

kwokcb · 2026-08-21T02:58:16Z


    // Options
    bool _saveNodePositions;
+    std::vector<ImVec4> _nodeMenuRects;


Used to track node menu location (hamburger) for hover hilighting

kwokcb · 2026-08-21T02:58:45Z

    // Create editor config and context.
    ed::Config config;
    config.SettingsFile = nullptr;
+    config.DragButtonIndex = 0;


Set mapping of mouse buttons.

kwokcb · 2026-09-13T02:16:53Z

@lfl-eholthouser, @jstone-lucasfilm : if you have some time could you take a look at this PR. It addresses a few issues but naturally not all but maybe useful to allow building on further for upcoming dev days. Thanks.

jstone-lucasfilm · 2026-09-13T20:24:41Z

Thanks for this proposal, @kwokcb! The rename consolidation and the Ctrl+F fix both look like clear improvements, and I'd be glad to see them merged soon. The new renameNode corrects the downstream update logic for node renames, committing on Enter rather than every keystroke is the right call, and disabling editor shortcuts around ed::End matches the pattern in the ImGui Node Editor widgets example.

On the mouse remap, I'd suggest we reconsider before merging. The PR moves panning to the middle button to avoid a conflict with a right-click menu, but ImGui Node Editor already resolves that conflict for us: its ContextMenuAction distinguishes a right-click from a right-drag, which is why the default config places both navigate and context menu on button 1. The blueprints example demonstrates the intended pattern with ed::ShowBackgroundContextMenu and ed::ShowNodeContextMenu. Building on that API rather than polling IsMouseReleased(1) would keep right-drag as pan, open the node menu on a right-click anywhere on the node, and remove the need for _nodeMenuRects and its hover tracking. It would also address a few potential issues in your current proposal:

Right-clicking a node body, pin, or link opens the Add Node popup, since only the hamburger rectangle is excluded.
A right-drag that ends on the background opens the Add Node popup as well.
Panning becomes unavailable on trackpads and two-button mice, which works against the goal of a keyboardless workflow.

If the hamburger feature is included in the current PR, I'd expect it to respond to a left click, matching the convention for that control.

The MacOS scaling change in Main.cpp seems separable from this work, and I'd suggest we take it up in its own PR with before-and-after screenshots. With our current ImGui version, skipping the content scale means fonts are rasterized at 1x and upscaled by the framebuffer scale, so this trades doubled text for blurred text on Retina displays. The usual approach for ImGui 1.88 is to rasterize at the scaled size and set FontGlobalScale to the inverse.

A few smaller notes:

documents/DeveloperGuide/GraphEditor.md still lists right-click as pan, and should follow whatever binding we settle on.
Moving addNodePopup after node creation leaves the search, add-pin, and read-only popups without the window padding style they previously shared.
The pin offset fix for the pins-on-border option is a good improvement, and worth a mention in the PR description.

Given the above, one option would be to split the rename and Ctrl+F work into a PR we can merge right away, with the context menu work following on the editor's native API.

Does that approach sound good to you?

kwokcb · 2026-09-16T11:51:08Z

Hi @jstone-lucasfilm

The keyboard and mouse interaction is tricky and quite hard to get correct. Fixing f key at same time is less complicated.

Keeping current main mappings sounds reasonable, if possible.

Mac change can be pulled out. I can remove

I won't have time currently to do work on this. Maybe better to unassigned me. I will post on Slack if anyone wants to complete this pr for dev days.

This reverts commit 6befba4.

kwokcb · 2026-09-17T01:33:00Z

Found a few cycles to restore default mapping and make hamburger be on LMB.

kwokcb · 2026-09-17T18:18:27Z

Documentation has been updated in app and docs.
Cleaned up padding code so it uses a global padding factor. Make all previous + new node menu have the same
padding.

…_editor

This changelist updates the runner images used in GitHub CI, moving away from the MacOS 14 and Ubuntu 22.04 environments ahead of their retirement in GitHub Actions, and replacing remaining uses of `ubuntu-latest` with explicit image versions. The following specific changes are included: - Move the oldest MacOS build from `macos-14` with Xcode 15.4 to `macos-15` with Xcode 16.0, as the MacOS 14 environment will be retired on November 2nd, 2026. - Move the oldest Linux builds from `ubuntu-22.04` to `ubuntu-24.04`, as the Ubuntu 22.04 environment will be retired on April 17th, 2027. - Replace `ubuntu-latest` with `ubuntu-26.04` in the JavaScript and release signing jobs, and move the Python SDist job to `ubuntu-26.04`. - Upgrade Playwright from 1.60 to 1.64, for compatibility with Ubuntu 26.04. - Raise the minimum Node version for JavaScript builds from 18 to 20.9, matching the requirements of current dependencies.

…on#3110) This adds `windows-11-arm` to the `Python Wheels` matrix so CI builds and tests native `win_arm64` wheels for Windows on Arm, using the existing cibuildwheel setup (`CIBW_ARCHS: auto64` resolves to ARM64 on that runner). GitHub's hosted `windows-11-arm` runners are free for public repositories. Changes (`.github/workflows/main.yml`, `wheels` job only): - Add `windows-11-arm` to the `os` matrix. - Exclude Python 3.9 and 3.10 on `windows-11-arm`: `actions/setup-python` has no ARM64 builds for them (`The version '3.9' with architecture 'arm64' was not found for Windows Enterprise.`, same for 3.10). - Name the ARM64 wheel artifacts `MaterialX_Python_Wheel_Windows_ARM64_3_<minor>` so they don't collide with the x64 Windows artifacts. Existing artifact names are unchanged. No source changes were needed.

…undation#3113) This changelist moves the nightly build into a separate `nightly` workflow in GitHub CI, which calls `main` as a reusable workflow with an `extended` input. Scheduled workflows are disabled by default in forks of a public repository, so forks no longer produce an empty nightly run each day with all jobs skipped. Fork maintainers who wish to run the nightly build may enable the `nightly` workflow in the Actions tab of their fork.

…editor

kwokcb added 9 commits August 16, 2026 20:44

Keyboardless graph editor (start)

1e25736

- RMB add node - RMB on hamburger in node -> popup menu. Add only delete for now Fix: CTRL-F search without also trigger focus (F).

Cleanup hamburger drawing

0bfd202

Add "rename" to menu.

- Fix rename logic which actually does not work in the property editor.

fda60c7

- Bypass imgui node editor F key invocation which is always triggered regardless of modifiers. This is the main source of the bug.

Take hamburger width into account for output pin placement.

eff17f3

- Consolidate renameNode() to new corrected logic in renameNode().

5cba4ea

- Disable hamburger on read-only nodes and disallow rename / delete on any read-only graphs.

Fix hamburger placement to be right aligned.

ea7ea58

- Extract out node width computation utility for us bye hamburger as well as previous pin placement.

Fix up to handle unexpected imgui side-effects for layouts which mess…

21b81c0

…ed up pin layouts.

Make hamburger have fixed alignment.

7d7e9fd

Disable RMB add popup on readonly graphs

Comment cleanup.

d3980d9

kwokcb commented Aug 21, 2026

View reviewed changes

kwokcb added 2 commits September 4, 2026 19:58

Merge branch 'main' into keyboardless_graph_editor

b2f7df6

Merge branch 'main' into keyboardless_graph_editor

a3b96f3

kwokcb mentioned this pull request Sep 13, 2026

MaterialX Graph Editor Keyboard-less UX #3037

Open

Fix double UI scale on Retina (Mac).

6befba4

jstone-lucasfilm mentioned this pull request Sep 13, 2026

Ctrl+F triggers framing of the node graph in MaterialX Graph Editor #3032

Open

kwokcb added 2 commits September 16, 2026 13:23

Revert "Fix double UI scale on Retina (Mac)."

294acd5

This reverts commit 6befba4.

Restore previous mouse mappings and make hamburger menu trigger on LMB.

b2de360

MatthieuBEAUD mentioned this pull request Sep 17, 2026

Add preview pin feature to Graph Editor #3079

Merged

kwokcb added 3 commits September 17, 2026 11:51

Update graph editor embedded help and developer guide.

0d26c91

Fix up padding so previous + node menu popups are consistent.

9637243

Merge branch 'main' into keyboardless_graph_editor

f4b717f

kwokcb added 4 commits September 23, 2026 20:55

Merge branch 'main' into keyboardless_graph_editor

5db50e0

Merge branch 'AcademySoftwareFoundation:main' into keyboardless_graph…

c689f00

…_editor

Merge branch 'main' into keyboardless_graph_editor

1091ff9

Merge branch 'AcademySoftwareFoundation:main' into keyboardless_graph…

1a83ae9

…_editor

kwokcb and others added 5 commits October 21, 2026 17:23

patch

8710253

Merge remote-tracking branch 'upstream/main' into keyboardless_graph_…

5c46a86

…editor

Conversation

kwokcb commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Updates

Implementation

Results

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kwokcb commented Sep 13, 2026

Uh oh!

jstone-lucasfilm commented Sep 13, 2026

Uh oh!

kwokcb commented Sep 16, 2026

Uh oh!

kwokcb commented Sep 17, 2026

Uh oh!

kwokcb commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kwokcb commented Aug 19, 2026 •

edited

Loading

kwokcb commented Sep 17, 2026 •

edited

Loading