Repository navigation
Release NoPoizen 1.2.0 with Forever poison monitoring and Classic support - #6
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5623fe8d8a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| end | ||
| if not Table(row) then | ||
| return nil | ||
| end |
There was a problem hiding this comment.
On Era, TBC, and Titan clients that expose C_PaperDollInfo.GetTemporaryEnchantmentInfo, the returned struct uses hasEnchant, expiration, and charges, as reflected by the deprecated GetWeaponEnchantInfo shim. This branch instead forces hasEnchant to true and reads nonexistent remainingTimeMs and chargesRemaining fields, so Classify receives nil timing data and returns unknown for every hand; because the presence of this API prevents the legacy fallback, poison monitoring never reaches missing or satisfied on these clients.
AGENTS.md reference: AGENTS.md:L5-L5
Useful? React with 👍 / 👎.
1 participant
Replace Forever diagnostics-only behavior with actual per-weapon poison detection using exact client spell/enchant data. Handle sparse multiple-coating rows, charge exhaustion, expiry, swaps, restrictions, HUD hand labels and event/polling lifecycle. Add separate Era/SoD, TBC, Titan and Mists mechanics while preserving Retail aura/talent behavior.
Clients: Retail, Forever, Era/Hardcore/SoD, Anniversary/TBC, Mists Classic and Titan Reforged. One codebase and private libchev 1.1.3 per addon.
Validation: 140 private regressions in both orders on Lua 5.1/5.2; all six startup/UI/transition/lifecycle profiles on both; 4 Python packaging/source tests, parsing, TOC, StyLua and exact vendor checks.
Source-backed and offline validation only. Live rendering, gameplay, audio and engine-level taint validation remain separate; the user requested implementation without waiting to level a Forever rogue. Exact evidence and remaining checks are in CLIENT_COMPATIBILITY.md.