Repository navigation
Add startup welcome messages and feedback links - #9
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 300a42c80a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| else | ||
| self:Disable() | ||
| end | ||
| self:PrintWelcomeMessage() |
There was a problem hiding this comment.
When a user has a mixed or partial upgrade where Core.lua is new but Welcome.lua was not loaded, PrintWelcomeMessage is undefined and this unconditional call throws from PLAYER_LOGIN. Although Enable() has already run, login produces a Lua error instead of degrading cleanly as intended, so check that the method exists before invoking it.
Useful? React with 👍 / 👎.
1 participant
Add the approved startup announcement with the installed version, supported client families, settings command, and addon-specific CurseForge/GitHub feedback links. Print once per login/UI reload through the shared private welcome controller. Clicking a feedback label selects only the fixed destination URL in a compact native-style copy window; unavailable registration or restricted UI falls back to plain URLs.
Vendor exact libchev 1.2.0 and pin CI to the same revision. Announcements run after normal startup and skip unavailable helpers so a partial installation cannot stop addon activation. The handlers accept only their own two fixed link payloads and never traverse foreign link/context tables.
Validation: 142 tests pass in both orders under Lua 5.1/5.2; client profiles, all Lua parsing, TOC paths, vendor hashes, release-script syntax and diff checks pass. NoPoizen additionally passes seven startup/copy-window/client smoke profiles and Python package/source tests. Live rendering remains separate.