Repository navigation
fix(uc): generate persistent device tokens for downloads - #9640
Merged
Merged
Conversation
JoaHuang
approved these changes
Sep 15, 2026
skysliences
approved these changes
Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UC download requests currently omit the device token required by some accounts, which can cause UC to return a QR-code prompt video instead of the requested file. Generate and persist a per-storage 24-byte UTDID and send its derived
uton UC download requests, using the AES-128-CBC/PKCS7 format described in #8030 (comment).The identity survives storage reloads, and Quark requests do not receive the UC token. Download headers continue to use the request-time cookie snapshot when UC rotates cookies. Empty download responses now return an error instead of indexing an empty result.
Validation:
go test -race ./drivers/quark_ucpassed, including an independent OpenSSL token fixture, persisted identity reload, UC/Quark request behavior, cookie rotation, and empty responses.go build ./drivers/quark_uc ./drivers/quark_uc_tvand the full application build passed./ping; real-account UC download/playback has not yet been confirmed.Fixes #8030.