Repository navigation
fix(quark): preserve post-upload identity across stale listings - #9664
Merged
okatu-loli merged 2 commits intoOct 13, 2026
Merged
okatu-loli merged 2 commits into
okatu-loli merged 2 commits into
Conversation
NovumOrbis
force-pushed
the
fix/quark-post-put-visibility-clean-20261004
branch
from
October 5, 2026 16:14
c5d174b to
bfa46d2
Compare
NovumOrbis
marked this pull request as ready for review
October 6, 2026 01:35
okatu-loli
approved these changes
Oct 13, 2026
JoaHuang
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve the identity of a successfully uploaded Quark/UC object across a short post-upload stale-listing window.
Quark may acknowledge an upload successfully while its directory listing still temporarily omits the newly created object. An immediate follow-up operation such as WebDAV DELETE can therefore fail during path resolution even though the upload itself succeeded.
Problem
Observed sequence:
201 Created.ObjectNotFound, so the follow-up DELETE cannot reachdriver.Remove.This is a read-after-write visibility issue rather than an upload failure.
Changes
driver.PutResult.internal/op.The bridge is keyed by:
and expires after one minute.
Normal provider/list lookup always runs first. The recent-write identity is used only as a fallback when the normal lookup succeeds but does not contain the recently written object.
Successful Remove invalidates the relevant recent-write identity. Rename/Move invalidate the source identity, and result-returning variants seed the destination only when they provide an authoritative non-nil object.
Safety
The bridge is bound to stable parent identity rather than pathname, preventing a child from being rebound to a newly-created same-name directory after the original parent is renamed, moved, or removed.
The change does not:
Validation
Validated on the current
main+ PR merge result with:go test ./drivers/quark_ucgo test -race ./drivers/quark_ucgo vet ./drivers/quark_ucgo test ./internal/opgo test -race ./internal/opgo vet ./internal/opgo test ./server/webdavgo test -race ./server/webdavgo vet ./server/webdavgofmtgit diff --checkNo real Quark/UC provider traffic was used during validation.
Related