Skip to content

Backfill all 56 Common flights (Fixes AB#3827769) - #3365

Draft
pedro romero vargas (p3dr0rv) wants to merge 3 commits into
devfrom
feature/common-flight-backfill-3827768
Draft

pedro romero vargas (p3dr0rv) wants to merge 3 commits into
devfrom
feature/common-flight-backfill-3827768

Conversation

@p3dr0rv

@p3dr0rv pedro romero vargas (p3dr0rv) commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Fixes AB#3827769, the complete implementation task under PBI 3827768.

One PR for all 56 retained production Common flights, expanding this existing PR rather than creating further batches or approval PRs.

  • Same owner identities from the developer-confirmed 56-flight review baseline, now represented by verified corporate aliases, not full names.
  • 35 Release, 16 Kill Switch, 5 Config; the four developer-assigned temporary team owners are preserved.
  • Four existing document links retained; 52 historical document gaps remain explicit through the initial-legacy-backfill report instead of fabricated documents.
  • Types follow the developer-delegated second pass and remain subject to owner validation in this PR. No completed individual owner sign-off is asserted before review.

Owner representation

Personal owner values use corporate aliases, for example pedroro, rather than display names or GitHub handles. All ten personal-owner aliases were verified against the corporate directory: 52 personal-name entries converted; four androididentity team-alias entries unchanged.

This is an identity-preserving format correction, not an ownership reassignment. The reviewed assignments and classifications are unchanged. Raw directory profiles and private review evidence are not included.

Existing documentation

Flight Same-repository document
EnableNativeDeviceCaManagementAppHandoff docs/premortem/ENABLE_NATIVE_DEVICE_CA_MANAGEMENT_APP_HANDOFF-Premortem.md
EnableBrokerWebViewExternalBrowserRedirect docs/premortem/ENABLE_BROKER_WEBVIEW_EXTERNAL_BROWSER_REDIRECT-Premortem.md
EnablePKeyAuthSubmitUrlOriginValidation docs/premortem/ENFORCE_PKEYAUTH_SUBMIT_URL_ORIGIN_VALIDATION-Premortem.md
EnforcePKeyAuthSubmitUrlOriginValidation docs/premortem/ENFORCE_PKEYAUTH_SUBMIT_URL_ORIGIN_VALIDATION-Premortem.md

The PKeyAuth document explicitly covers both the master safety switch and the separate enforcement rollout. The other 52 declarations intentionally omit a document rather than linking private material or inventing historical evidence.

Dependency and review

  • Merge the already-open checker dependency AzureAD/microsoft-authentication-library-common-for-android#3364 first. Both PRs target dev, not a feature-integration branch.
  • The developer approved initial legacy gaps based on the frozen target-trusted cutover plus verified metadata-only changes, with owner/type review in this same PR. There is no separate per-flight approval PR.
  • The declaration/key/default must exist unannotated at the cutover, merge base and current target. New flights, changed defaults/runtime behavior and later metadata edits cannot use the exception.
  • Keep this PR draft pending the dependency and owner/type validation. All 56 are implemented; there are no remaining Common backfill batches.
  • Blocking enforcement and the later monthly audit skill are not prerequisites for this metadata backfill.

Scope

Only annotations in CommonFlight.java: one Java file, 172 added annotation lines.

The alias follow-up changes exactly 52 personal owner arguments. Every other source character is preserved apart from equivalent line endings; team aliases, types, document links, keys, defaults, ordering and runtime code are unchanged.

No providers, intentional Broker/Common differences, ECS, test pins or document contents changed. No private CSVs, directory/team-membership evidence, historical-owner notes or private document links are published.

Validation

JDK 17; from common-java-root:

.\gradlew.bat :common4j:assemble :common4j:test --tests 'com.microsoft.identity.common.java.flighting.CommonFlightsManagerTest' --tests 'com.microsoft.identity.common.java.flighting.FlightMetaInteropTest' :common4j:spotbugsMain --console=plain --no-daemon
  • Common4j assembly and SpotBugs passed after alias normalization.
  • 7 focused tests passed: six flight-manager tests and one Java/Kotlin annotation interoperability test; no failures/errors/skips.
  • All 56/56 parsed owner/type entries match the reviewed identities after verified corporate-alias normalization; all four team aliases and four document links are unchanged.
  • The committed inventory differs from the prior full backfill only in the 52 personal owner arguments and commit ID. Declaration IDs/keys, raw and normalized defaults, types, document links, ordering and metadata-stripped runtime shape are unchanged.
  • The unchanged checker dependency previously passed 33 tooling tests and distribution packaging; those tooling tests were not rerun for this owner-string-only follow-up.
  • Against prospective dependency target db4c8d6f8, committed source c800c6cba reports 56 checked, 0 findings, 52 recorded historical gaps. Every gap was checked against the exact undocumented legacy declaration set.
  • Against current dev (aea799488), the direct scan correctly reports 52 missing-document advisories because the trusted cutover policy has not merged yet. These are dependency sequencing, not owner/type errors or an excuse to self-authorize a baseline.
  • The private review input hash is unchanged.

Hosted CI, owner review and merge remain pending. Full SDK/lab/device suites were not run locally for this metadata-only change. No credential/feed configuration changes were committed.

Changelog

changelog:none: legacy metadata backfill; no SDK behavior/API-shape change.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@p3dr0rv pedro romero vargas (p3dr0rv) added the changelog:none No changelog entry or version increment is required. label Nov 20, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 6 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@p3dr0rv pedro romero vargas (p3dr0rv) changed the title Backfill documented Common flight metadata (Fixes AB#3827769) Backfill all 56 Common flights (Fixes AB#3827769) Nov 20, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:none No changelog entry or version increment is required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant