Repository navigation
Conversation
The generated tests now record what the list names. A list with text and without image skips the preview PNG, and a strategy the platform cannot do gives a compile warning instead of being skipped silently. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The setting covers accessibility snapshots only, so it must not change the preview PNG. What remains of this branch is the compile warning for a listed strategy that cannot run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AllDmeat
changed the title
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
voiceover_snapshotsused to skip a listed strategy silently where it cannot run, so[text]on tvOS recorded no text and said nothing. Now the generated file gives a compile warning. What tests record does not change.The docs now also say plainly that
imagemeans the accessibility PNG, not the regular snapshot, and that this setting does not affect the preview PNG.Before
voiceover_snapshots[text][image][image, text][image, text]After
voiceover_snapshots[text][image][image, text][image, text]Targets without the key get no new warning, since they did not ask for anything.
Compatibility
No reference changes. A target that builds with warnings as errors and lists a strategy it cannot run will stop compiling until it removes that strategy from the list.
The template is embedded in the CLI, and
publish.ymlrebuildsBinaries/and bumps the version, so this PR does neither.Validation
On Xcode 27.1:
make test: 159 tests, zero failures. The strategy test covers both warnings and checks that the preview PNG comparison is generated for every value.make test-ios: 55 tests, zero failures, with the generated[text]test comparing both text and PNG references.[text]file compiles on macOS in a separate package and shows the text warning.Not run: a tvOS build, and the Example baseline suite. The
imagewarning is checked as generated text, not seen in a build.🤖 Generated with Claude Code