Skip to content

Quality Control. - #62

Open
zrodevkaan wants to merge 11 commits into
mainfrom
feat/quality-control
Open

Quality Control.#62
zrodevkaan wants to merge 11 commits into
mainfrom
feat/quality-control

Conversation

@zrodevkaan

@zrodevkaan zrodevkaan commented Sep 10, 2026

Copy link
Copy Markdown

Quality Control submission guidelines.

Quality Control #.4 may be removed/obsolete if we go with the plugin monorep.

@zrodevkaan

Copy link
Copy Markdown
Author

Merged branch due to old commit history.

@zrodevkaan
zrodevkaan requested review from TheLazySquid and zerebos and removed request for TheLazySquid September 10, 2026 04:28
Reword #1. and #2 to allow user-elected supression, not a lesser replacement.
@zerebos

zerebos commented Sep 10, 2026

Copy link
Copy Markdown
Member

Why did you manually number everything? They were intentionally left as 1. so everything after the first number was automatically incremented as per commonmark spec.

@zrodevkaan

zrodevkaan commented Sep 10, 2026

Copy link
Copy Markdown
Author

I don't know anything about commonmark spec. I will adjust that.

For reference; my IDE did that.

@zerebos zerebos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added sections don't match the existing voice and diction and seem hyper-specific which could lead to many future arguments, nitpicks, and exceptions.

There is also needless ordered list number churn.

Definitely need more opinions in this area cc: @doggybootsy

@zrodevkaan

zrodevkaan commented Sep 10, 2026

Copy link
Copy Markdown
Author

I feel like in past conversations we agreed in whats listed? has and wildcard selectors, or authors who submit seemingly looking ai generated plugins, asking for proof of actual knowledge.

We know automating quests can cause account suspension or quest suspension.

I added onto the dont waste resources area with known wasteful systems.

We've seen plugins being submitted with old discord vars (also circles back to AI generative area) that dont work and clearly havent been tested. along with multiple plugins just not caring about React crashes and just submitting fixes, which aggravated DevilBro with many repo issues.

I recall talking about licenses but I could be wrong.

@Huderon

Huderon commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

I think that first point in Quality Control you could probably break out into a “Usability” heading, similar to what already exists in the theme guidelines. It could almost be word for word the same with the caveat about plugins that explicitly hide/remove features. That caveat will also need some work though as it still excludes stuff like BetterBlockedUsers or whatever that DevilBro one is that hides messages from blocked users.

For the second and third, I’d create a new heading called “Testing” and throw them in there with a bit of rewording. Then, all that’s really left is licensing, which could also be its own heading

@zrodevkaan

Copy link
Copy Markdown
Author

BetterBlockedUsers is okay to be excluded. Its under the accessibility category imo along with it being user elected.

I think I should probably break it into more sections than it just being under quality control.

Ill continue it after work.

@Huderon

Huderon commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Yeah, I think BetterBlockedUsers is fine, but what you've got there at the moment excludes it, I think. Copying out that Usability heading and adding something like this below the first point would be enough for me

Exceptions can be made for plugins that are explicitly intended to remove or obscure undesirable native functionality

@zrodevkaan

Copy link
Copy Markdown
Author

Maybe we can narrow it down to just user elected removal?

@Huderon

Huderon commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Yeah, I think that's what "explicitly intended" implies, but it probably could use a bit more rewording

@Huderon

Huderon commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

You can probably also remove that excerpt from the Discord guidelines. It doesn't really help in defining what a selfbot is

@zrodevkaan

zrodevkaan commented Sep 10, 2026

Copy link
Copy Markdown
Author

Exceptions can be made for plugins that are explicitly intended to remove or obscure undesirable native functionality

This is too vague, of course this is discretion of the staff/reviewer but this just creates a loophole for lazy overrides.

I think the more specific we get here the better if we want to target developer code and the end users performance as a whole.

Comment on lines +39 to +46
**Exceptions:** #1 and #2 does not apply to addons that intentionally remove or block functionality for privacy/security reasons including but not limited to:.
- Privacy/Security
- Accessibility
- Performance
- Content/moderation control
- This only accounts for removing *specific* type of content including but not limited to: disabling embeds, nsfw previews.

These are not required to be feature-complete replacements, as the addons purpose is intentional removal.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo this is redundant since you're removing something rather than overriding it

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same argument here

This is too vague, of course this is discretion of the staff/reviewer but this just creates a loophole for lazy overrides.

Comment thread docs/plugins/publishing/guidelines.md Outdated
Comment on lines +62 to +63
- If the reviewing staff collectively agree that a submission appears to be AI-generated or otherwise not primarily written by the submitter,
the plugin will be denied and the author may be asked to demonstrate competence or proof of knowledge (e.g. explaining the code, making a live modification, or a similar test) before resubmission will be considered.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be in the guidelines

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like it should be as we are being transparent with our userbase? We usually end up telling them in a support forum anyway.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go in the process rather than the guidelines if at all

Comment thread docs/plugins/publishing/guidelines.md Outdated
Comment thread docs/plugins/publishing/guidelines.md Outdated
Comment thread docs/plugins/publishing/guidelines.md
include anything that spams Discord's API or Protobuf (cloud sync).

As taken from the Discord™️ guidelines
> Don’t use the services to do harm to Discord. Among other things, this includes trying to gain access to, intentionally overburdening or attacking our systems; scraping our services without our written consent, including by using any robot, spider, crawler, scraper or other automatic device, process or software; selling, licensing or otherwise commercialising content or data obtained from our services; transmitting viruses or other malicious code to our services; using any unauthorised software designed to modify the services; abusing or defrauding us or our payment systems; copying, dismantling or reverse-engineering any of our services or using our intellectual property without permission; and misusing our reporting or customer service mechanisms.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of this doesn't really pertain to self-botting and just makes things more confusing imo. This definition also doesn't really help clear up what counts as self-botting; we allow things like automatically changing status when a game is launched but not scheduling messages, both of which are pretty ambiguous about being invoked by user action.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one's going to require a bit of soul searching on the part of you lot 🤣

There's a clear line that has been crossed by plugins like the one you mentioned that automatically sets user status when they start a game, and it's going to make it so much harder to find a definiton that fits while making allowances for stuff like that. I would say stick to a standard definition and have plugins like that add a prompt before changing status or w/e

@zrodevkaan zrodevkaan Sep 10, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scheduling messages

Not only was that before the whole self bot chat, that was after the Nitro feature got added.

Comment thread docs/themes/publishing/guidelines.md Outdated
Comment thread docs/plugins/publishing/guidelines.md Outdated
- Using non-user APIs,
- Bypassing nitro features,
- Animated status,
- Message logging.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't risk a user's account, shouldn't be enumerated here imo. Covered by the following rule.

@zrodevkaan zrodevkaan Sep 10, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does risk the user account? Its a suspension, it affects your account standing.
Not what he was arguing, discussion held elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants