Repository navigation
fix(rest): do not warn about the missing real ip header on internal routes - #779
Merged
Merged
Conversation
…outes The other services call the internal routes directly and from the address of the reverse proxy. Every such call logged the warning "real ip header not found", and warnings are reported to the error tracker as events: one event for every user a nightly sweep looks up. On internal routes (`/<area>/_internal/...`) the missing header is now logged at debug level. Everywhere else the warning stays, so a reverse proxy that stops sending the header is still noticed. The resolved client address is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The other services call the internal routes directly and from the address of the reverse proxy. Every such call logged the warning
real ip header not found, and warnings are reported to the error tracker as events: one event for every user a nightly sweep looks up, tens of thousands a night.On internal routes (
/<area>/_internal/...) the missing header is now logged at debug level. Everywhere else the warning stays, so a reverse proxy that stops sending the header is still noticed. The resolved client address is unchanged in every case.A unit test pins which paths count as internal.
🤖 Generated with Claude Code