Repository navigation
Conversation
Add a Codacy badge to README.md
Removed default D-rating.
Setup CI with Git Actions.
Added gitignore node-modules. Added Nodemon library.
Set up Local server.
Set up first middleware.
Configured Express app.
Backend app set for deploy on Heroku.
Removed unnecesary comments
Removed yarn.lock file
added Procfile.
edited Procfile
Added middleware for default response.
added organization field for users
fixed date of birth validation bug.
fix phone number bug
Fixed bug on signup.
Fixed Sponsor bug on events model.
Fixed bug on Auth.
Added linked Event to Announcement.
Modified admin Controller for better response.
Added functionality for updating User and Admin records.
added postBy to Events.
Implemented image upload functionality.
fix bug img
Added image upload capability to Events page.
The app connected to Mongo on import, signed tokens with a hardcoded secret and repeated the same CRUD blocks in every controller. This turns it into something we can maintain and deploy: * config comes from the environment and fails fast when STRING or JWT_SECRET is missing * the Mongo connection lives in db.js, so the Express app can be imported without a database and the tests run against mongodb-memory-server * every writable route validates its payload with Joi and answers 400 with field level details * events, funds and announcements share one CRUD factory, and a single error handler formats every failure response * pino replaces console logging and /health reports the connection state * 69 tests across 8 suites, with a coverage gate in CI * dependencies, ESLint config, GitHub Actions, Docker and the README are brought up to date
Release the API rework: environment configuration, Joi validation, a shared CRUD factory, structured logging with a health endpoint, integration tests with coverage gates, and refreshed tooling and CI.
Three things have tripped people up on a fresh clone: the STRING variable actually holds the Mongo URI, the first test run is slow because mongodb-memory-server downloads a mongod binary, and the pre-commit hook fails if Node is not on PATH. Worth writing down.
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| - | - | MongoDB Credentials | 7d7d62f | src/app.js | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and relevant motivation and context.
List any dependencies that are required for this change.
All pull requests should be related to open issues. Indicate the issue(s) bellow and remove this line:
Fixes #(issue number 1) #(issue number 2 if applicable)
How Has This Been Tested?
Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code etc.
Screenshots (if applicable, else remove this line / section)
Checklist: