Repository navigation
[IMPROVEMENT] Add tests for --stdin, --udp and --tcp - #2414
Open
Deepak-negi11 wants to merge 4 commits into
Open
Deepak-negi11 wants to merge 4 commits into
Deepak-negi11 wants to merge 4 commits into
Conversation
… into the C options
Deepak-negi11
force-pushed
the
test/cli-network-options
branch
from
October 24, 2026 23:04
5b46935 to
ded8b3f
Compare
Collaborator
CCExtractor CI platform finished running the test files on linux. 81/237 tests matched the approved output:
156 tests do not match the approved output. That is the pass/fail verdict. Whether this branch caused it is a separate question, answered below.
Compared with the tip of master — test 9744, commit 0bf2a94:
Pass there, fail here:
Fail on both but produce different output — behaviour moved even though the verdict did not:
Compared with the commit this branch was cut from — test 9750, commit d7eb132:
Pass there, fail here:
Fail on both but produce different output — behaviour moved even though the verdict did not:
This branch changes the behaviour of 30 test(s) relative to the tip of master. Those are the ones worth looking at; anything else in the list fails the same way on both sides. |
Collaborator
CCExtractor CI platform finished running the test files on windows. 171/237 tests matched the approved output:
66 tests do not match the approved output. That is the pass/fail verdict. Whether this branch caused it is a separate question, answered below.
Compared with the tip of master — test 9693, commit af4b28d:
Fail on both but produce different output — behaviour moved even though the verdict did not:
Fail there, pass here:
Compared with the commit this branch was cut from: the same run as the tip of master (test 9693), so the comparison above already covers it. This branch changes the behaviour of 42 test(s) relative to the tip of master. Those are the ones worth looking at; anything else in the list fails the same way on both sides. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
Reason for this PR:
Sanity check:
Repro instructions:
cd src/rust && cargo test --lib cli_testsExample of what they catch: remove
self.set_input_format_type(InFormat::Bin)from the--tcphandling inparser.rs. All 214 parser tests still pass;test_tcp_reaches_cfails.I also checked that these options work end to end on macOS with
Closed Caption EIA.tsfrom https://streams.videolan.org/streams/ts/:cat sample.ts | ccextractor --stdinccextractor --udp 127.0.0.1:7312ccextractor sample.ts --sendto 127.0.0.1:7311intoccextractor --tcp 7311Part of #2408. Depends on #2411.
Problem
--stdin,--udpand--tcphad no test that passes them on the command line.What this adds
--stdinsetsinput_sourceto stdin and no timeout (live_stream-1), as in v0.94.--udpsetsinput_sourceto network and the port (both spellings); theaddr:portandsrc@addr:portforms set the address and the source address.--tcpsetsinput_sourceto TCP, the port, and the binary (RCWT) input format.UNTESTED_OPTIONS(10 → 7).Testing
cargo test(445 passed),cargo fmt --check,cargo clippy -- -D warnings.