Repository navigation
[FIX] Bound CDP caption data by packet length - #2431
Closed
harshalsp07 wants to merge 2 commits into
Closed
harshalsp07 wants to merge 2 commits into
harshalsp07 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CDP parser now checks that the declared caption triplets fit before the packet footer and that the copied bytes fit in the demuxer buffer. Malformed counts return
CCX_EINVAL.The parser previously trusted the 5-bit
cc_countand could read beyond a short packet while copying caption data.Added three cases to the repository Check suite: reject the issue’s malformed 16-byte CDP, accept a valid one-triplet CDP, and reject a write that exceeds the destination buffer.
Validation:
ccx_gxf.crejected the malformed packet, preserved all three caption bytes from a valid packet, and rejected insufficient destination capacity.upstream/masterreports an AddressSanitizer stack-buffer-overflow in the original copy loop.git diff --checkpassed.gpacpackage is not installed, so the full application build and end-to-end GXF repro remain unverified.