Repository navigation
London | 26-SDC-July | Shaghayegh Far| Sprint 2 | Chat-app - #126
shaghayeghfar wants to merge 1 commit into
Conversation
shaghayeghfar
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on this, you are the first person I have seen complete this using Java.
Part of the task is to deploy the app. Is the chat app deployed anwhere we can test it? It's usually a good idea to include this in the PR text.
One of the tasks is to add an additional feature beyond simple messaging. What feature did you add?
I've got a few questions about the code you have built.
| import org.springframework.web.bind.annotation.RestController; | ||
|
|
||
| @RestController | ||
| @CrossOrigin(origins="http://localhost:63342") |
There was a problem hiding this comment.
There are a lot of hard coded URLs. As this is the first time I'm seeing this code, is there anything you could do that would help me find all this important info more easily?
| class ChatAppApplicationTests { | ||
|
|
||
| @Test | ||
| void contextLoads() { |
There was a problem hiding this comment.
You comitted a test class but it is empty. Was that intentional?
| @@ -0,0 +1,6 @@ | |||
| package com.shaghayegh.chat_app.repository; | |||
| import com.shaghayegh.chat_app.model.Message; | |||
| import org.springframework.data.jpa.repository.JpaRepository; | |||
There was a problem hiding this comment.
You import a lot of these packages - can you explain what they do and why you chose them?
| import java.util.List; | ||
|
|
||
| @RestController | ||
| @CrossOrigin(origins= "http://localhost:63342") |
There was a problem hiding this comment.
Can you explain what this decorator does?
| messageInput.value = ""; | ||
| feedback.textContent = ""; | ||
|
|
||
| loadMessages(); |
There was a problem hiding this comment.
Do you need to call loadmessages after doing a send message?
LonMcGregor
added
Reviewed
2 participants
Learners, PR Template
Self checklist
Task code
CYF-1162
Changelist
Implemented a full-stack chat application with a Java Spring Boot backend, PostgreSQL database, and HTML/CSS/JavaScript frontend. Added user names, message timestamps, message persistence, and automatic message updates.