Update install vm script - #15110
Merged
jan-cerny merged 2 commits intoSep 17, 2026
Merged
Update install vm script#15110
Conversation
Mab879
requested review from
jan-cerny,
matusmarhefka and
vojtapolasek
as code owners
September 9, 2026 21:21
jan-cerny
requested changes
Sep 15, 2026
| } | ||
| DISTRO_EXTRA_REPO = { | ||
| "centos8": "http://mirror.centos.org/centos/8-stream/AppStream/x86_64/os/", | ||
| "centos9": "http://mirror.stream.centos.org/9-stream/AppStream/x86_64/os/", | ||
| "centos9": "http://mirror.centos.org/centos/9-stream/AppStream/x86_64/os/", |
| "centos8": "http://mirror.centos.org/centos/8-stream/AppStream/x86_64/os/", | ||
| "centos9": "http://mirror.stream.centos.org/9-stream/AppStream/x86_64/os/", | ||
| "centos9": "http://mirror.centos.org/centos/9-stream/AppStream/x86_64/os/", | ||
| "centos10": "http://mirror.stream.centos.org/10-stream/AppStream/x86_64/os/", |
Member
There was a problem hiding this comment.
centos10 needs to be added to KNOWN_DISTROS
Mab879
force-pushed
the
fix_install_vm_help_text
branch
from
September 15, 2026 21:46
dbcf1af to
58bdef0
Compare
jan-cerny
reviewed
Sep 16, 2026
| ] | ||
|
|
||
| # put here any unreleased distro in development that needs to be tested | ||
| # and any working osinfo known to be used by default when installating it | ||
| UNRELEASED_DISTROS_AND_OSINFO = { | ||
| "rhel10": "rhel9-unknown" |
Member
There was a problem hiding this comment.
The --help output now looks broken:
--osinfo OSINFO Specify OSInfo for virt-install command.
--osinfo details: 'For unreleased distros, these are the following
default data used as input {}.
I had to look at the source code for RAM and figured that being clear for RAM isn't a bad idea.
Mab879
force-pushed
the
fix_install_vm_help_text
branch
from
September 16, 2026 17:24
58bdef0 to
101b43e
Compare
|
@Mab879: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
jan-cerny
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Rationale: