Skip to content

Bootstrap 5 - #602

Open
BigSpaceships wants to merge 76 commits into
developfrom
bootstrap-5
Open

Bootstrap 5#602
BigSpaceships wants to merge 76 commits into
developfrom
bootstrap-5

Conversation

@BigSpaceships

Copy link
Copy Markdown
Contributor

What

Update to bootstrap 5
Head's up the slideshow isn't done yet but everything else should be (I'll update this when I fix the slideshows)

Why

Because it's cool and up to date now

Test Plan

Run locally, also it's running at https://conditional-dev-plsss-conditional.apps.okd4.csh.rit.edu/dashboard/

Env Vars

I don't think so :)

Documentation

Nope, NA

Checklist

  • Tested all changes locally
  • wrote too much stuff

@csh-sonarqube-community

Copy link
Copy Markdown

Passed Quality Gate passed

Issues

Measures

Project ID: ComputerScienceHouse_conditional_b4074151-bbfd-4fc3-b87d-10f1c1f625ab

View in SonarQube

@BigSpaceships
BigSpaceships requested a review from a team September 10, 2026 19:39
@pikachu0542

Copy link
Copy Markdown
Member

on the directorship attendance form, when i hover over one of the options in the directorship dropdown, it only applies the hover style to half of the row
image

@pikachu0542

Copy link
Copy Markdown
Member

i think my profile picture might need to be bigger on mobile 🤣
image

@pikachu0542

Copy link
Copy Markdown
Member

Can these be left aligned?
image

@pikachu0542

Copy link
Copy Markdown
Member

The profile picture needs to be smaller when in mobile resolutions on the intro evals and the spring evals pages too
image
image

@pikachu0542

Copy link
Copy Markdown
Member

The profile picture needs to be smaller when in mobile resolutions on the intro evals and the spring evals pages too

Same thing on the gatekeep page

@pikachu0542

Copy link
Copy Markdown
Member

can you add a bit more space above the detailed description on the MP form?
image

@pikachu0542

Copy link
Copy Markdown
Member

The media upload kinda feels like its randomly shoved in there. Can you add a header or something to make it clear that it is separate from the links?
image

@pikachu0542

Copy link
Copy Markdown
Member

Nitpick: I think the spacing above the page title can be reduced.
image

@pikachu0542

Copy link
Copy Markdown
Member

Can you add more spacing between the TLDR text and the time commitment header?
image

@pikachu0542

pikachu0542 commented Sep 10, 2026

Copy link
Copy Markdown
Member

In the list of submitted major projects, images are not being displayed at all, and it says "no images uploaded" even when there should be images. For reference, Mary's project on your branch has no images, but on prod it does have an image

@pikachu0542 pikachu0542 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks really good overall, but there are a few things that should be fixed. See my comments above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants