Put cb login activation code in the URL fragment - #195
Merged
sfc-gh-abrightwell merged 2 commits intoSep 17, 2026
Merged
Conversation
Keep the code out of the query string so it is not sent to the dashboard server or written to access logs. Co-authored-by: Cursor <cursoragent@cursor.com>
Our specs checked the login URL we print, but not the one we hand to the browser, which is the URL that has to carry the code in the fragment. We now assert the full expected URL at both call sites.
sfc-gh-abrightwell
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cb loginnow opens/account/verify-cli/{id}#code={code}instead of?code=.location.hash(and still accepts query-string URLs until this ships). Specs assert the printed login URL uses#code=and not?code=.Test plan
crystal spec spec/cb/login_spec.crcb login, confirm the printed / opened URL uses#code=#code=URL still activates on the dashboard verify-cli pageMade with Cursor