handle remote-auth methods in multi-step MFA flows - #1154
Open
wojcik91 wants to merge 30 commits into
Open
Conversation
wojcik91
force-pushed
the
mfa_engine_pt2
branch
2 times, most recently
from
September 10, 2026 15:53
91c344a to
5eb9e29
Compare
wojcik91
force-pushed
the
mfa_engine_pt2
branch
from
September 10, 2026 18:33
5eb9e29 to
9659de0
Compare
moubctez
reviewed
Sep 11, 2026
| if preshared_key.is_empty() { | ||
| return Err(MfaError::MfaRejected { | ||
| message: | ||
| "mobile approval failed: proxy returned an empty preshared key" |
Contributor
There was a problem hiding this comment.
Suggested change
| "mobile approval failed: proxy returned an empty preshared key" | |
| "mobile approval failed: Edge returned an empty pre-shared key" |
filipslezaklab
previously approved these changes
Sep 11, 2026
moubctez
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues from initial MVP implementation of MFA flows. Adds handling mobile auth and OIDC for multi-step flows.
Finishes DefGuard/defguard#3045