[Anna Malchow-Perryman (apman)]

This was a regression from #660 that I mistakenly accepted as the new normal in #661

[Copilot]

Copilot review overview

🟡 Changes recommended

Visual baselines, regression coverage, and outdated resource documentation must be addressed.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1 · 1 · 1

Open (3)

• Regenerate visual baselines for the geometry change · New
• Add regression coverage for top-level Menu BasedOn inheritance · New
• Correct contract comment describing dark margin values · New

What changed in this PR

Restores Linux menu styling regressed by PR #660.

Changes:

• Restores top-level MenuItem theme inheritance.
• Adjusts dark-theme submenu chevron spacing.

File	Description
Controls/​Menu.axaml	Restores the base MenuItem theme.
Accents/​MenuResources.axaml	Revises dark chevron margins.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Anna Malchow-Perryman (apman)]

I dug further into this. I agree that the contract comment should not claim that the dark value was simply pinned from the pre-#660 resource: pre-#660 and the original post-#660 Linux token were both 0 0 7 0, while the value in this PR (2 0 10 0) is an empirical geometry correction.

The reason the correction can nevertheless be needed is that #660 changed the source of the menu styling: the Linux theme stopped inheriting Fluent's MenuItem theme/resources and began using the copied Linux-owned templates/resources. That changes the effective layout/measurement context around the chevron even though the Linux margin token itself was not edited. In other words, this is compensating for the changed template/resource contract, not restoring a value that #660 changed in-place.

I don't see a principled derivation of 2 0 10 0 from #660 itself. What we can establish is that it restores the pre-#660 rendered geometry: with the restored pre-#661 baselines, the shared popup bounds and the MenuDemo/ContextMenuDemo dark tests match; the remaining MenuFlyoutDemo difference is a separate one-pixel chevron translation. I therefore agree the comment should explicitly describe this as a compatibility/geometry adjustment validated against the pre-#660 rendering, rather than saying both values were previously resolved values.

Posted by Copilot (agent), on behalf of Anna Malchow-Perryman (@apman).

[Copilot]

Copilot review overview

🟢 Approval recommended

The focused changes correctly restore the intended Linux menu appearance.

Review effort: Balanced
Findings: None

Resolved since last review (3)

• Regenerate visual baselines for the geometry change
• Add regression coverage for top-level Menu BasedOn inheritance
• Correct contract comment describing dark margin values

[randy-but-a-ro]

🤖 Pull request was approved automatically: the AI review is complete and all its review threads are resolved. 🎉

Integration Details

{
	"deliveryId": "7e65f120-b79b-11f1-92e4-3b579ff06bfb",
	"headSha": "074c8dc17da6c715ee15ef84cfc1b7b1fc4df416",
	"reviewer": "copilot-pull-request-reviewer[bot]"
}