Repository navigation
Exclude the trailing empty line after a final forced break from the last baseline - #946
Merged
Merged
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
staging-devin-ai-integration
Bot
force-pushed
the
devin/1790388547-inline-box-baseline
branch
from
September 26, 2026 02:28
34ba910 to
591e041
Compare
staging-devin-ai-integration
Bot
force-pushed
the
devin/1790388547-inline-box-baseline
branch
from
September 28, 2026 21:35
591e041 to
2a72f0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#832 already made inline boxes export their baseline. This PR is what's left of the original change: one fix to the last baseline reported by inline layout.
When inline content ends in a forced line break (e.g.
X<br>), Parley still emits an empty line after it, for text-editor semantics. #939 already leaves that line out of the measured height. Butlast_baselinewas still taken fromlines().last(), which is that empty line. So an inline-block ending in<br>was positioned one line too low relative to the text beside it.Tests
tests/blitz-tests/tests/inline_box_baseline.rswith four tests.trailing_br_does_not_move_last_baselinefails on main. The other three cover inline-block baseline alignment that main already handles correctly: single line, last line of a multi-line box, and a scroll container falling back to its bottom margin edge.css/CSS2,css-inline,css-align,css-flexbox,css-grid,css-tablesandcss-display: identical results before and after (7043 tests / 26035 subtests passing).Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/af67bcfb5eb947fa81ba768501f4c276
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/af67bcfb5eb947fa81ba768501f4c276?variant=devin-insiders
Requested by: @nicoburns
WPT results
Subtests: 1 newly passing, 0 newly failing (net +1).
Full diff (1 changed tests)
+ FAIL => PASS [1/1] +1 css/css-text/letter-spacing/letter-spacing-end-of-line-002.htmlGenerated by the WPT workflow.