Repository navigation
Conversation
|
I'll fix CI failures and address comments from users with write access that start with 'DevinAI' or '@devin'.
|
Member
Author
|
Merged upstream as linebender#834. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM Contributions: Written by Devin (Cognition AI) under human direction.
Since linebender#790,
calculate_content_widthsonly samplesrunning_max_widthat forced breaks and at the end, so a negative-width in-flow inline box (Blitz passes inline-block margin boxes, e.g. an emptyinline-blockwithmargin-right: -50px) can makemax < min:CSS Sizing 3 (see also csswg-drafts#12076) requires the max-content size to be floored by the min-content size, so this adds
max_width = max_width.max(min_width)before returning, plus a regression test. Fixes WPTcss/css-sizing/min-content-le-max-content.tentative.htmlin Blitz once picked up.Changelog
Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/da7669e341814cc7976e4ebf32b7eacb
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/da7669e341814cc7976e4ebf32b7eacb?variant=devin-insiders
Requested by: @nicoburns