Skip to content

Floor max-content width by min-content width - #56

Closed
nicoburns wants to merge 2 commits into
mainfrom
devin/1790016609-content-width-floor
Closed

nicoburns wants to merge 2 commits into
mainfrom
devin/1790016609-content-width-floor

Conversation

@nicoburns

Copy link
Copy Markdown
Member

LLM Contributions: Written by Devin (Cognition AI) under human direction.

Since linebender#790, calculate_content_widths only samples running_max_width at forced breaks and at the end, so a negative-width in-flow inline box (Blitz passes inline-block margin boxes, e.g. an empty inline-block with margin-right: -50px) can make max < min:

boxes [100, -50]  ->  min = 100, max = 50

CSS Sizing 3 (see also csswg-drafts#12076) requires the max-content size to be floored by the min-content size, so this adds max_width = max_width.max(min_width) before returning, plus a regression test. Fixes WPT css/css-sizing/min-content-le-max-content.tentative.html in Blitz once picked up.

Changelog

Fixed

Parley

  • Layout::calculate_content_widths no longer returns a max-content width smaller than the min-content width when the layout contains negative-width inline boxes.

Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/da7669e341814cc7976e4ebf32b7eacb
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/da7669e341814cc7976e4ebf32b7eacb?variant=devin-insiders
Requested by: @nicoburns

@staging-devin-ai-integration

Copy link
Copy Markdown

I'll fix CI failures and address comments from users with write access that start with 'DevinAI' or '@devin'.

  • Disable automatic comment, CI, and merge conflict monitoring

@nicoburns
nicoburns changed the base branch from main to v0.11.x September 21, 2026 18:51
@nicoburns
nicoburns changed the base branch from v0.11.x to main September 21, 2026 18:51
@nicoburns

Copy link
Copy Markdown
Member Author

Merged upstream as linebender#834.

@nicoburns nicoburns closed this Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant