Skip to content

fix(interactions): remove unbound generic parameter from ApplicationCommandInteraction aliases - #1606

Open
shiftinv wants to merge 2 commits into
masterfrom
fix/interaction-type-aliases
Open

shiftinv wants to merge 2 commits into
masterfrom
fix/interaction-type-aliases

Conversation

@shiftinv

@shiftinv shiftinv commented Sep 4, 2026

Copy link
Copy Markdown
Member

Summary

Adding the (unbound) generic ClientT parameter to the ApplicationCommandInteraction aliases1 meant that e.g. isinstance(x, CommandInteraction) would not work.
This was changed in 8c3af23 as part of #1332, but things should work fine without it as well.

ref: https://canary.discord.com/channels/808030843078836254/942319505915412500/1540732874955689997

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running uv run nox -s lint
    • I have type-checked the code by running uv run nox -s pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Footnotes

  1. Having this many aliases seems a little silly to me at this point, anyway.

@shiftinv shiftinv added this to the v2.13 milestone Sep 4, 2026
@shiftinv shiftinv added this to disnake Sep 4, 2026
@github-project-automation github-project-automation Bot moved this to Todo in disnake Sep 4, 2026
@read-the-docs-community

Copy link
Copy Markdown

Documentation build overview

📚 disnake | 🛠️ Build #34396912 | 📁 Comparing 7ffab08 against latest (0da8970)

  🔍 Preview build  

1 file changed
± whats_new.html

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

1 participant