Repository navigation
fix: loosen overly strict type assertions - #1617
Merged
Merged
Conversation
…ence this is always a list in cpython (https://github.com/python/cpython/blob/v3.15.0/Python/_warnings.c#L99-L107), but maybe not in pypy? but then again, do we even really support pypy? anyhow.
shiftinv
added
s: needs review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1616 by turning the assertion back into a
pyright: ignore.I manually checked all the assertions added in #1381 (whiuch caused the linked issue), the vast majority of them are completely fine, but a few more can be loosened further without much issue.
Checklist
uv run nox -s lintuv run nox -s pyright