Skip to content

feat(net): vendor smoltcp and test it only when it changes - #2585

Merged
fslongjin merged 1 commit into
DragonOS-Community:masterfrom
fslongjin:feat-vendor-smoltcp
Nov 5, 2026
Merged

fslongjin merged 1 commit into
DragonOS-Community:masterfrom
fslongjin:feat-vendor-smoltcp

Conversation

@fslongjin

Copy link
Copy Markdown
Member

Summary

  • Vendor the smoltcp revision already used by the kernel and depend on it by path, so kernel builds no longer fetch that git revision.
  • Keep the crate outside the kernel workspace so its tests and dev-dependencies stay out of the kernel lockfile.
  • Add a workflow that runs formatting, MSRV clippy, feature tests, checks, and a short fuzz run only when this crate or its workflow changes.

Test plan

  • Confirm the kernel still builds for x86_64 with the path dependency.
  • Confirm the smoltcp workflow runs on changes under kernel/crates/smoltcp and does not run for unrelated changes.
  • Confirm formatting, clippy, the feature test matrix, and the fuzz job pass on the vendored tree.

Made with Cursor

Import the smoltcp revision already used by the kernel into the tree and depend on it by path, so builds no longer fetch that git revision. Keep its tests and dev-dependencies out of the kernel workspace, and run formatting, clippy, feature tests, and fuzzing only when that crate or its workflow changes.

Signed-off-by: longjin <longjin@DragonOS.org>
@github-actions github-actions Bot added the enhancement New feature or request label Nov 5, 2026
@fslongjin
fslongjin merged commit 4961542 into DragonOS-Community:master Nov 5, 2026
58 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant