Repository navigation
Conversation
Translate the merged VFS flag word into the statfs(2) ST_* ABI and always advertise ST_VALID, matching Linux calculate_f_flags(). Report PAGE_SIZE as the socket inode block size, and add dunitest coverage for statfs flag translation and sockfs metadata. Fix the gvisor runner corrupting its readv blocklist by redirecting awk output onto the input file, normalize the heavy readv entry in both memory-size directions, and use busybox applets so the FAT32 rootfs does not depend on unsuffixed tools. Correct the partial_bad_buffer_test spelling in the whitelist and blocklist filename. Validated with make kernel, cargo fmt --check, host and QEMU guest unix_socket_stat/sysfs_statfs runs, guest gvisor statfs_test (8 passed, 1 skipped), and guest partial_bad_buffer_test (19/19 after blocklist). Signed-off-by: longjin <longjin@dragonos.org>
fslongjin
marked this pull request as ready for review
November 5, 2026 06:52
Member
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
github-actions
Bot
added
Bug fix
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes the P0 and P1 follow-ups from the gVisor blocklist revalidation and the Unix socket
statfs/permission work, in one change set.P0: gVisor blocklist infrastructure
run_tests.shcorrupting its readv blocklist:awk ... "$BLOCKLIST_FILE" > "$BLOCKLIST_FILE"truncated the input before it was read. Rewrite through a sibling temp file and replace atomically withbusybox mv -f.ReadvTestNoFixture.TruncatedAtMaxin both directions, so a persisted rootfs reused on a lower-memory machine cannot leave the 2GiB case enabled below the threshold. Matching now tolerates leading whitespace,#Test, and# Testforms.partial_bad_buffer_testspelling in both the whitelist and the blocklist filename.P1: sockfs / statfs metadata semantics
StatFsFlagswith the Linux UAPIST_*values and translate the merged VFS mount/superblock flag word inFrom<SuperBlock> for PosixStatfs, mirroring Linuxcalculate_f_flags():ST_VALIDMS_DIRSYNC(Linux has no correspondingST_*translation)MMArch::PAGE_SIZEas the sockfs inodeblk_size, matching Linux pseudo-filesystemi_blocksize().SuperBlock::flagscarries the MountFS-merged mount + superblock flags.Tests
sysfs_statfs_test: newStatfsFlags.MountFlagsUseStatfsAbicovering theMS_RELATIME | MS_NOSYMFOLLOW→ST_*translation.unix_socket_stat_test: assertst_blksize == getpagesize(), sockfsf_flags == ST_VALID, and thatfchmodupdates mode/ctime without touching atime/mtime (avoids relying on inode timestamp initialization).Validation
make kernelcd kernel && cargo fmt --all -- --checkunix_socket_stat_test: 6/6 passedsysfs_statfs_test: 4/4 passedunix_socket_stat_test/sysfs_statfs_test: passedstatfs_test: 8 passed, 1 skippedpartial_bad_buffer_test: 19/19 after the blocklist entry, with onlyPartialBadBufferTest.SendMsgTCPstill blockedScope
No web frontend changes. No unrelated refactoring.