Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## latest #3270 +/- ##
=======================================
Coverage 73.30% 73.31%
=======================================
Files 446 446
Lines 108277 108305 +28
Branches 17346 17351 +5
=======================================
+ Hits 79372 79400 +28
Misses 28629 28629
Partials 276 276 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is another instance found by @odow and his LLM fuzzer. The issue seems to be that when upgrading a row to an equality, the implied dual bounds on other rows are not notified. This means that there can be a stale implied bound lying around, and in this three column LP example, it is used for some additional reduction (I think it was a substitution). This lead to an incorrect return status in the test I added (instance directly from @odow )
The fix I added was to reset all the dependent implied bounds when upgrading the row to an equality (I will test this over the weekend). @fwesselm This is another presolve change where I'm a bit out of my depth.
Checklist
latestbranch