Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## latest #3281 +/- ##
==========================================
+ Coverage 73.31% 73.57% +0.26%
==========================================
Files 446 446
Lines 108299 109532 +1233
Branches 17347 17547 +200
==========================================
+ Hits 79396 80592 +1196
- Misses 28627 28663 +36
- Partials 276 277 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mathgeekcoder
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! Minor suggestions if you wanted some improvements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
kCacheLineSize, so that it is easier to modify it and recompile Highs on a machine with different cache line size.HighsSpinMutexto highlight thatstd::this_thread::yield()is the correct instruction to use on AArch64.Checklist
latestbranchRelated issue
Closes #3221