Skip to content

Fix 3221 - #3281

Merged
jajhall merged 4 commits into
latestfrom
fix-3221
Sep 18, 2026
Merged

jajhall merged 4 commits into
latestfrom
fix-3221

Conversation

@filikat

@filikat filikat commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Description

  • Substitute hard coded value of 64 for cache line size with a constant kCacheLineSize, so that it is easier to modify it and recompile Highs on a machine with different cache line size.
  • Update the "ToDo" comment in HighsSpinMutex to highlight that std::this_thread::yield() is the correct instruction to use on AArch64.

Checklist

  • I have read the contributing guidelines
  • This PR targets the latest branch
  • Tests are passing
  • Documentation was updated where relevant
  • This PR is not primarily AI-generated (per the AI contributions policy in CONTRIBUTING.md)

Related issue

Closes #3221

@filikat filikat self-assigned this Sep 14, 2026
@codecov

codecov Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.57%. Comparing base (b440ef0) to head (c3aee6e).
⚠️ Report is 105 commits behind head on latest.

Files with missing lines Patch % Lines
highs/parallel/HighsSplitDeque.h 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #3281      +/-   ##
==========================================
+ Coverage   73.31%   73.57%   +0.26%     
==========================================
  Files         446      446              
  Lines      108299   109532    +1233     
  Branches    17347    17547     +200     
==========================================
+ Hits        79396    80592    +1196     
- Misses      28627    28663      +36     
- Partials      276      277       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mathgeekcoder mathgeekcoder left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Minor suggestions if you wanted some improvements.

Comment thread highs/parallel/HighsSchedulerConstants.h
Comment thread highs/parallel/HighsSplitDeque.h Outdated
Comment thread highs/parallel/HighsSplitDeque.h Outdated

@mathgeekcoder mathgeekcoder left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jajhall
jajhall merged commit a147022 into latest Sep 18, 2026
558 checks passed
@jajhall
jajhall deleted the fix-3221 branch September 18, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants