Repository navigation
Removed presolve_light option, and introduced presolve_mode option - #3536
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## latest #3536 +/- ##
==========================================
+ Coverage 75.60% 75.63% +0.02%
==========================================
Files 461 461
Lines 113649 113741 +92
Branches 17905 17911 +6
==========================================
+ Hits 85927 86023 +96
+ Misses 27434 27430 -4
Partials 288 288 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
filikat
reviewed
Nov 4, 2026
filikat
left a comment
filikat
left a comment
Collaborator
There was a problem hiding this comment.
Looks good!
Just missing a test for the various modes and documentation for the new option.
filikat
reviewed
Nov 4, 2026
| } else if (options->presolve_mode == kPresolveModeLight) { | ||
| setRulesForLightMode(); | ||
| } else if (options->presolve_mode == kPresolveModeFull) { | ||
| // Full presolve uses all presolve rules |
Collaborator
There was a problem hiding this comment.
My love of symmetry tells me that this (and above) should be setRulesForFullMode()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
presolve_lightoption is too limited now that there is the initial sweep, sopresolve_lightis removed, andpresolve_modeoption is introduced. It has four valuesSetting
presolve_rules_offcan be used to modify the rules that are on, and rules are also switched off if they are incompatible with the postsolve that may occur.Setting
presolve_light = kHighsOnStringis now achieved withpresolve_mode = kPresolveModelLightThe structure of setting of rules on/off has been revised heavily in `HPresolve::chooseRules``
Checklist
latestbranch