Skip to content

Improve find_package(highs) for HiPO - #3567

Merged
galabovaa merged 3 commits into
latestfrom
win-dll-lookup
Nov 6, 2026
Merged

galabovaa merged 3 commits into
latestfrom
win-dll-lookup

Conversation

@galabovaa

@galabovaa galabovaa commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Description

Improve find_package(highs) for HiPO with every BLAS route

Record the BLAS the build used in a generated highs-blas-dependency.cmake
instead of always calling find_dependency(BLAS), which failed for bundled
OpenBLAS and static vcpkg OpenBLAS. Link BLAS PRIVATE so consumers of the
shared extras library need no BLAS at configure time. Keep a user-supplied
BLAS_LIBRARIES for consumers of static extras.

Checklist

  • I have read the contributing guidelines
  • This PR targets the latest branch
  • Tests are passing
  • Documentation was updated where relevant
  • This PR is not primarily AI-generated (per the AI contributions policy in CONTRIBUTING.md)

@galabovaa galabovaa self-assigned this Nov 6, 2026
@codecov

codecov Bot commented Nov 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.66%. Comparing base (372b34e) to head (899cc62).
⚠️ Report is 13 commits behind head on latest.

Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #3567      +/-   ##
==========================================
- Coverage   75.66%   75.66%   -0.01%     
==========================================
  Files         461      461              
  Lines      113822   113823       +1     
  Branches    17914    17913       -1     
==========================================
- Hits        86129    86128       -1     
- Misses      27405    27407       +2     
  Partials      288      288              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@galabovaa
galabovaa merged commit 0dd188f into latest Nov 6, 2026
605 checks passed
@galabovaa
galabovaa deleted the win-dll-lookup branch November 6, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant