Take the timeline out of the dashboard menu - #46
Merged
Merged
Conversation
Hidden, not deleted. TimelinePage, its route, its props and its styles all stay exactly where they are — the nav entry is one line and putting it back is the same line. Worth being clear about why that matters here. The page's layout was only just fixed: it had no phone rules at all and overflowed its own column at every width. What has still never been looked at is how the path itself reads inside that container — jsdom has no SVG geometry, so every render of it this week fabricated the milestone positions. Deleting the page would throw away working code over a question nobody has answered yet. The onboarding timeline is a different component and is untouched. App.tsx's 'timeline' screen renders TimelineZoomed between the grade picker and the demographic survey; only the dashboard's TimelinePage entry goes.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Deploying timeline-prototype with
|
| Latest commit: |
b83e659
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9b749df5.timeline-prototype.pages.dev |
| Branch Preview URL: | https://chore-hide-timeline-nav.timeline-prototype.pages.dev |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dashboard menu is now Dashboard · Calendar · Profile · Settings.
One line, and deliberately only one.
Hidden, not deleted
TimelinePage, its route, its props and its styles all stay exactly where they are. Putting the entry back is the same line that removed it.That is worth being explicit about, because the obvious alternative — deleting the page — would throw away working code over a question nobody has answered. Its layout was fixed three commits ago: it had no phone rules at all, and
1frlet it overflow its own column at every width. What has still never been looked at is how the path itself reads inside that container. jsdom has no SVG geometry, so every render of it this week stubbedgetTotalLength/getPointAtLengthand fabricated the milestone positions.So the page is in a known-good container with an unknown interior. Hiding it costs nothing and keeps the option open.
There are two timelines, and this touches one
TimelineZoomedTimelinePageApp.tsxstill has its own'timeline'screen andsetScreen('timeline')call; those belong to the onboarding one and are not affected.Testing
377 tests, tsc, eslint and build all clean. Nothing was testing the nav entry, so nothing needed changing.