Stop expense-driven Home Insights chart refreshes by MelvinBot · Pull Request #106796 · Expensify/App

MelvinBot · 2026-11-12T22:54:54Z

Explanation of Change

Remove the expense-signature subscription and expense counter from the Home Insights chart refresh key so incoming expense updates no longer rerun its Search or queue a refresh behind an RHP. Preserve initial load, actual Home revisits, chart selection, reconnect, configuration resolution, workspace membership, and app-foreground refresh behavior. Other Home cards and full Insights are unchanged.

Add unit coverage for repeated expense-signature changes, expense changes behind an RHP, Home return, chart switching, equivalent configuration identity, reconnect, and configuration resolution.

AI Tests

Passed: 177 tests across five focused suites (Home Insights refresh, shared tab refresh, Recently Added, Your Spend, and ToDo counts).
Passed: full lint, changed-file lint, typecheck, spelling, direct React Compiler validation of the changed hook, Storybook smoke test, and coding-standards review (no violations).
Full Jest run exceeded the 10-minute limit before completion; no test failures were reported before timeout.
Formatting validation unavailable: this checkout has no prettier npm script; alternate formatter invocations were denied by execution permissions.
Compiler check-changed failed because the environment supplied an empty base ref (origin/); direct hook compilation passed instead.
Web runtime verification remains blocked: the ready browser session displayed a blank page, returned zero UI nodes, and had no recent network entries. No chart behavior was verified in-browser.

Fixed Issues

$ #106791
PROPOSAL: #106791 (comment)

Tests

Manual test plan (not a claim that these steps have passed):

Sign in to the development build with an account that has access to a workspace with enough expenses to populate Home Insights. Open Home and let the selected chart finish loading.
Monitor network requests for the selected chart's Search (for example, searchKey=spendOverTime). Identify chart requests by their payload rather than counting every Home Search request.
From another session, create an expense in a workspace accessible to the first account and allow the update to reach that account. Repeat with multiple expenses, then edit an amount or date and delete an expense included in the selected chart. Keep the first session on Home without changing charts, foregrounding the app, or changing workspace membership.
Verify that these incoming additions, edits, and deletions do not trigger another selected-chart search and that the chart retains its loaded snapshot. Verify that the other Home cards, including ToDos when applicable, still update as before.
Navigate to another tab, then return to Home. Verify that the selected chart requests fresh data and reflects the relevant expense changes.
Change the selected chart. Verify that a search for the newly selected chart runs and its data loads.
With Home open, disconnect and reconnect the network. Verify that the selected chart requests fresh data after reconnecting.
Open a right-hand panel (RHP) over Home and close it without changing anything. Verify that closing it does not trigger another selected-chart search.
Open an RHP over Home again. From the other session, add, edit, and delete relevant expenses, wait for the updates to arrive, then close the RHP. Verify that no expense-driven chart search runs while the panel is open or merely because it closes.
Verify that no errors appear in the JS console during these steps.

Verify that no errors appear in the JS console

Offline tests

QA Steps

QA plan (pending execution on a staging build containing this change):

Open Home with an account that has enough workspace expenses to populate Insights, and let the selected chart finish loading.
Monitor network requests for the selected chart's Search (for example, searchKey=spendOverTime), distinguishing them from searches for other Home cards.
From another session, create multiple expenses in a workspace accessible to the first account, edit a relevant expense's amount or date, and delete a relevant expense. Allow each update to reach the first account while it remains on Home without changing charts, foregrounding the app, or changing workspace membership.
Verify that no additional selected-chart searches run solely because of those updates and that the chart retains its loaded snapshot. Verify that other Home cards, including ToDos when applicable, retain their existing live-update behavior.
Leave Home for another tab and return. Verify that the selected chart fetches fresh data and reflects the relevant expense changes.
Select a different chart and verify that its search runs and its data loads.
Disconnect and reconnect the network while on Home. Verify that the selected chart fetches fresh data after reconnecting.
Open and close an RHP over Home without making changes. Verify that closing it does not trigger a chart search.
Repeat with expense additions, edits, and deletions arriving from the other session while the RHP is open. Verify that those updates do not trigger chart searches or queue a chart refresh for when the RHP closes.
Verify that no errors appear in the JS console during these steps.

Verify that no errors appear in the JS console