Skip to content

feat(storage): add bucket IP filtering samples and tests - #14594

Open
nidhiii-27 wants to merge 2 commits into
mainfrom
samples-bucket-ip-filter-python
Open

feat(storage): add bucket IP filtering samples and tests#14594
nidhiii-27 wants to merge 2 commits into
mainfrom
samples-bucket-ip-filter-python

Conversation

@nidhiii-27

Copy link
Copy Markdown
Contributor

Add Python code samples and tests demonstrating Cloud Storage Bucket IP filtering.

Fixes: b/544985518

[Generated-by: AI]

Add Python code samples and tests demonstrating Cloud Storage Bucket IP filtering.

Fixes: b/544985518

[Generated-by: AI]
@product-auto-label product-auto-label Bot added api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples. labels Sep 9, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces Python code snippets and tests demonstrating Google Cloud Storage bucket IP filtering features, including creating, enabling, disabling, retrieving, listing, and deleting IP filtering rules. The review feedback highlights several potential bugs and improvement opportunities: handling potential IndexError exceptions when executing the scripts from the command line without arguments, defensively checking for None values to avoid TypeError exceptions on list operations, and refactoring direct self-assignments to prevent linter warnings or accidental code removal that would break the SDK's change registration.

Comment thread storage/samples/snippets/storage_delete_ip_filtering_rules.py
Comment thread storage/samples/snippets/storage_disable_ip_filtering.py Outdated
Comment thread storage/samples/snippets/storage_delete_ip_filtering_rules.py
Comment thread storage/samples/snippets/storage_delete_ip_filtering_rules.py
Comment thread storage/samples/snippets/storage_disable_ip_filtering.py
Comment thread storage/samples/snippets/storage_enable_ip_filtering.py
Comment thread storage/samples/snippets/storage_enable_ip_filtering.py
Comment thread storage/samples/snippets/storage_enable_ip_filtering.py
Comment thread storage/samples/snippets/storage_create_bucket_ip_filtering.py
Comment thread storage/samples/snippets/storage_get_ip_filtering.py
Address review feedback regarding self-assignment, defensive None checks, and CLI arg handling.

[Generated-by: AI]
@nidhiii-27
nidhiii-27 marked this pull request as ready for review September 9, 2026 08:53
@nidhiii-27
nidhiii-27 requested review from a team as code owners September 9, 2026 08:53
@snippet-bot

snippet-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants