Fix temporary service plist suffix - #23878
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #23869.
launchctl bootstraprejects plist contents loaded from a path without a.plistsuffix with exit status 5. The temporary file introduced forbrew services runin #23869 did not specify a suffix, so macOS could notbootstrap the generated service file.
This gives that
Tempfilea.plistsuffix and extends the existing test toassert both the suffix and cleanup behaviour.
@MikeMcQuaid, I am very sorry I missed the required
.plistsuffix in#23869. I reproduced the failure locally and tested this correction against
the real macOS
launchctl, not only the mocked unit path:successfully with the suffix;
main,brew services run cc-connectsucceeded;launchctl printshowed the generated.plistpath and all values from~/.homebrew/services/cc-connect.env;running.
Steps to reproduce the regression on macOS before this change:
The last command fails while executing
launchctl bootstrapagainst atemporary path without a
.plistsuffix.Verification:
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?OpenAI Codex (GPT-5) was used to prepare and test this follow-up under the
contributor's direction. The diff was reviewed, the regression test was run
red then green, the full
brew lgtm --onlinegate passed and the change wasverified with a live macOS
launchctlservice run as described above.