Repository navigation
Overlay compscale - #281
Merged
Merged
Conversation
…f/compute builders hybrid_component_tags gives each component of a hybrid pair_style its LAMMPS address (name plus occurrence index when a style repeats); the existing overlay helpers now build on it, and list-based variants are exposed for callers that assemble the hybrid from explicit components.
The averaging and integration stages now describe each end of the alchemical path as a list of components (style, name, pair_coeff): the first half of the pair lists is the initial potential, the second half the final one. A single component reproduces the previous command stream exactly; several components install hybrid/overlay for the pure end states and one hybrid/scaled with per-component computes for the switch. The duplicated Monte Carlo swap block is folded into _add_swap_fixes.
The routine rewrites the potential component by component: each pair_coeff is mapped to the input and to the output composition and the pair lists become [initial components, final components], which the alchemy driver turns into hybrid/overlay end states and one hybrid/scaled switching path. A plain potential contributes one component as before. Input validation forbids pair_mode overlay in mode alchemy, where the two entries are the two ends of the switch, requires '* *' pair_coeff for composition_scaling (the transformation renumbers the atom types), and checks the element ordering on every overlay component instead of only the first.
Golden command streams for the averaging and integration stages of a ZrCu composition scaling given as eam/fs overlaid with a zero pair style (baseline B13), plus the plain single-component stream; unit tests for the hybrid sub-style tagging helpers, the pair-list rewrite, and the new input validation rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.