Repository navigation
fix: relax incompatible dependency pins - #2
Closed
WhaleK1123 wants to merge 1 commit into
Closed
WhaleK1123 wants to merge 1 commit into
WhaleK1123 wants to merge 1 commit into
Conversation
requirements.txt currently pins versions that are mutually incompatible and won't install on a fresh machine: - numpy==2.4.4 requires Python>=3.11, but MinkowskiEngine==0.5.4 needs numpy<2.0 (uses numpy.distutils). Relax to numpy>=1.24,<2.0. - scipy==1.17.1 requires Python>=3.11. Relax to scipy>=1.10,<1.16. - torch==2.6.0+cu124 has no NVIDIA Blackwell (sm_120) support. Use torch>=2.7 so the model runs on RTX 50-series GPUs. Verified FUSER (FUSER model, 591.9M params) builds and loads its fuser.safetensors checkpoint on torch 2.8.0+cu128 with numpy 1.26.4 / scipy 1.15.2. NOTE: patched MinkowskiEngine (see NVIDIA/MinkowskiEngine build-CUDA-12.8 fix) is still required for the sparse-conv backend to compile with current CUDA toolchains.
Owner
|
Thanks for the PR! I've already updated requirements.txt and the README install instructions on main with an equivalent fix, so I'll close this PR without merging. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
requirements.txtpins contradictory versions that cannot be installed on afresh machine, and can't run on NVIDIA Blackwell (sm_120) GPUs.
Changes
numpy==2.4.4→numpy>=1.24,<2.0(2.4.x needs Python>=3.11, andMinkowskiEngine==0.5.4requiresnumpy<2.0).scipy==1.17.1→scipy>=1.10,<1.16(1.16+ needs Python>=3.11).torch==2.6.0+cu124→torch>=2.7(2.6.0+cu124 has no Blackwell sm_120support).
Verification
Confirmed the FUSER model (591.9M params) builds and loads
ckpts/fuser.safetensorsontorch 2.8.0+cu128,numpy 1.26.4,scipy 1.15.2. Note: theMinkowskiEnginesparse-conv backend still needsthe CUDA-12.8 compatibility patch in
NVIDIA/MinkowskiEngine#639
to compile on current toolchains.
Closes #1.