Repository navigation
[wip] test: signing - #10767
Closed
notjaywu wants to merge 7 commits into
Closed
[wip] test: signing#10767notjaywu wants to merge 7 commits into
notjaywu wants to merge 7 commits into
Conversation
The explicit squirrel and nsis targets replaced --dir, so the unpacked step built and signed both installers. The dist step builds them again from --prepackaged. Use --win --dir to sign only the stock Insomnia.exe here. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…pper signing The tosign step moved every .dll and .exe file, so files that already had a valid signature were signed again. Move only files without a valid signature. Set signExts in the dist step to skip the wrapper Insomnia.exe that is signed before electron-builder re-packages it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Do not cancel a running release build. Build inso before any Windows signing step. Verify the wrapper and inso.exe signatures so a failed signing stops the job early. Always remove the DigiCert client certificate on Windows. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…missing artifacts Read the base64 certificate from an environment variable instead of writing the secret into the script text. Fail the artifact upload when no file matches. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… to skip Windows signing The unpacked step needs an nsis target, otherwise electron-builder does not write resources/app-update.yml and NSIS auto-update fails. Add the skip_windows_signing workflow input and SKIP_WINDOWS_SIGN env so test builds do not use signing tokens. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE