Skip to content

[wip] test: signing - #10767

Closed
notjaywu wants to merge 7 commits into
developfrom
release/test-signing
Closed

notjaywu wants to merge 7 commits into
developfrom
release/test-signing

Conversation

@notjaywu

Copy link
Copy Markdown
Contributor

DO NOT MERGE

notjaywu and others added 7 commits November 12, 2026 17:46
The explicit squirrel and nsis targets replaced --dir, so the unpacked step
built and signed both installers. The dist step builds them again from
--prepackaged. Use --win --dir to sign only the stock Insomnia.exe here.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…pper signing

The tosign step moved every .dll and .exe file, so files that already had a
valid signature were signed again. Move only files without a valid signature.
Set signExts in the dist step to skip the wrapper Insomnia.exe that is signed
before electron-builder re-packages it.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Do not cancel a running release build. Build inso before any Windows signing
step. Verify the wrapper and inso.exe signatures so a failed signing stops the
job early. Always remove the DigiCert client certificate on Windows.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…missing artifacts

Read the base64 certificate from an environment variable instead of writing
the secret into the script text. Fail the artifact upload when no file matches.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… to skip Windows signing

The unpacked step needs an nsis target, otherwise electron-builder does not
write resources/app-update.yml and NSIS auto-update fails. Add the
skip_windows_signing workflow input and SKIP_WINDOWS_SIGN env so test builds
do not use signing tokens.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@notjaywu notjaywu changed the title test signing [wip] test: signing Nov 13, 2026
@notjaywu notjaywu closed this Nov 13, 2026
@notjaywu
notjaywu deleted the release/test-signing branch November 13, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant